Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753445Ab3FJNs3 (ORCPT ); Mon, 10 Jun 2013 09:48:29 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:34734 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753360Ab3FJNs2 (ORCPT ); Mon, 10 Jun 2013 09:48:28 -0400 Date: Mon, 10 Jun 2013 15:48:17 +0200 From: Michael Holzheu To: HATAYAMA Daisuke Cc: Vivek Goyal , Jan Willeke , Martin Schwidefsky , Heiko Carstens , linux-kernel@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature Message-ID: <20130610154817.3275672f@holzheu> In-Reply-To: References: <1370624161-2298-1-git-send-email-holzheu@linux.vnet.ibm.com> <1370624161-2298-3-git-send-email-holzheu@linux.vnet.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13061013-3548-0000-0000-000005A225C5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 31 On Mon, 10 Jun 2013 22:36:57 +0900 HATAYAMA Daisuke wrote: > > -static int setup_kdump_elfcorehdr(void) > > +void elfcorehdr_free(void) > > { > > - size_t elfcorebuf_sz; > > - char *elfcorebuf; > > - > > - if (!OLDMEM_BASE || is_kdump_kernel()) > > - return -EINVAL; > > - s390_elf_corehdr_create(&elfcorebuf, &elfcorebuf_sz); > > - elfcorehdr_addr = (unsigned long long) elfcorebuf; > > - elfcorehdr_size = elfcorebuf_sz; > > - return 0; > > + if (!elfcorehdr_newmem) > > + return; > > + vfree(elfcorehdr_newmem); > > kfree is correct here? You are right, I fixed that! Thanks! Michael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/