Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 3 Oct 2002 12:15:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 3 Oct 2002 12:15:56 -0400 Received: from neon-gw-l3.transmeta.com ([63.209.4.196]:45841 "EHLO neon-gw.transmeta.com") by vger.kernel.org with ESMTP id ; Thu, 3 Oct 2002 12:15:55 -0400 Date: Thu, 3 Oct 2002 09:22:58 -0700 (PDT) From: Linus Torvalds To: Christoph Hellwig cc: Michael Clark , Kevin Corry , , Subject: Re: [Evms-devel] Re: [PATCH] EVMS core 2/4: evms.h In-Reply-To: <20021003161405.A20832@infradead.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1160 Lines: 27 On Thu, 3 Oct 2002, Christoph Hellwig wrote: > > root device should be in do_mount.c and not in obscure headers. No, they should _not_ be in do_mount.c either. They should be in the driver registration, and do_mount.c should not have a random list of devices. I'm not accepting do_mount.c expansion here, simply because I don't want to help a horribly broken interface. You can always use a hex number (which is what things like lilo will install anyway, I believe, rather than using the "root=/dev/xxx" command line), and if people get too tired about remembering numbers, maybe somebody who cares will step up to the plate and write a reverse of "__bdevname()" and do it right. Hint: see __bdevname in fs/block_dev.c, and realize that it does the "kdev->name" translation without _any_ tables at all. Think about doing the same the other way, by just walking the registered block devices. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/