Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189Ab3FJTkX (ORCPT ); Mon, 10 Jun 2013 15:40:23 -0400 Received: from www.linutronix.de ([62.245.132.108]:58158 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838Ab3FJTkV (ORCPT ); Mon, 10 Jun 2013 15:40:21 -0400 Date: Mon, 10 Jun 2013 21:39:58 +0200 (CEST) From: Thomas Gleixner To: Yinghai Lu cc: Ingo Molnar , "H. Peter Anvin" , Bjorn Helgaas , "Rafael J. Wysocki" , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Gordeev Subject: Re: [PATCH v3 10/27] genirq: Split __irq_reserve_irqs from irq_alloc_descs In-Reply-To: <1370644273-10495-11-git-send-email-yinghai@kernel.org> Message-ID: References: <1370644273-10495-1-git-send-email-yinghai@kernel.org> <1370644273-10495-11-git-send-email-yinghai@kernel.org> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1186 Lines: 37 On Fri, 7 Jun 2013, Yinghai Lu wrote: > /** > - * irq_alloc_descs - allocate and initialize a range of irq descriptors > - * @irq: Allocate for specific irq number if irq >= 0 > + * __irq_reserve_descs - reserve and initialize a range of irq descriptors Did you even bother to run docbook ? No you didn't. Otherwise you'd have noticed that documentation for __irq_reserve_descs is not the right thing for a function named __irq_reserve_irqs. > + * __irq_reserve_descs - reserve and initialize a range of irq descriptors The function only reserves a range of irq descriptors and does not initialize them. > + > +/** > + * irq_alloc_descs - allocate and initialize a range of irq descriptors Again you document non matching function names. > +int __ref > +__irq_alloc_descs(int irq, unsigned int from, unsigned int cnt, int node, > + struct module *owner) Sloppy as usual along with a sucky changelog as usual..... Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/