Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754319Ab3FKDHd (ORCPT ); Mon, 10 Jun 2013 23:07:33 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:48747 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325Ab3FKDHb (ORCPT ); Mon, 10 Jun 2013 23:07:31 -0400 Message-ID: <51B6946B.4050803@linaro.org> Date: Tue, 11 Jun 2013 08:37:23 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Sachin Kamat CC: linux-kernel@vger.kernel.org, thierry.reding@gmail.com, patches@linaro.org, sparclinux@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH 01/15] sparc,leon: Convert to use devm_ioremap_resource References: <1370864113-17895-1-git-send-email-tushar.behera@linaro.org> <1370864113-17895-2-git-send-email-tushar.behera@linaro.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 44 On 06/10/2013 05:33 PM, Sachin Kamat wrote: > On 10 June 2013 17:04, Tushar Behera wrote: >> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") >> introduced devm_ioremap_resource() and deprecated the use of >> devm_request_and_ioremap(). >> >> Signed-off-by: Tushar Behera >> CC: sparclinux@vger.kernel.org >> CC: "David S. Miller" >> --- >> * Not compile tested. >> arch/sparc/kernel/leon_pci_grpci1.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/sparc/kernel/leon_pci_grpci1.c b/arch/sparc/kernel/leon_pci_grpci1.c >> index 7739a54..23497f4 100644 >> --- a/arch/sparc/kernel/leon_pci_grpci1.c >> +++ b/arch/sparc/kernel/leon_pci_grpci1.c >> @@ -536,10 +536,10 @@ static int grpci1_of_probe(struct platform_device *ofdev) >> >> /* find device register base address */ >> res = platform_get_resource(ofdev, IORESOURCE_MEM, 0); >> - regs = devm_request_and_ioremap(&ofdev->dev, res); >> - if (!regs) { >> + regs = devm_ioremap_resource(&ofdev->dev, res); >> + if (IS_ERR(regs)) { >> dev_err(&ofdev->dev, "io-regs mapping failed\n"); > > You may remove the above error message as devm_ioremap_resource prints > its own error messages. > Ok. I will remove the error message. I will do the same for other instances too. Thanks. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/