Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737Ab3FKEbb (ORCPT ); Tue, 11 Jun 2013 00:31:31 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:63618 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079Ab3FKEb3 (ORCPT ); Tue, 11 Jun 2013 00:31:29 -0400 Message-ID: <51B6A819.9020603@linaro.org> Date: Tue, 11 Jun 2013 10:01:21 +0530 From: Tushar Behera User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Sachin Kamat CC: linux-kernel@vger.kernel.org, thierry.reding@gmail.com, patches@linaro.org, Mark Brown , Liam Girdwood Subject: Re: [PATCH 11/15] regulator: ti-abb: Convert to use devm_ioremap_resource References: <1370864113-17895-1-git-send-email-tushar.behera@linaro.org> <1370864113-17895-12-git-send-email-tushar.behera@linaro.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2282 Lines: 64 On 06/10/2013 05:31 PM, Sachin Kamat wrote: > On 10 June 2013 17:05, Tushar Behera wrote: >> Commit 75096579c3ac ("lib: devres: Introduce devm_ioremap_resource()") >> introduced devm_ioremap_resource() and deprecated the use of >> devm_request_and_ioremap(). >> >> Signed-off-by: Tushar Behera >> CC: Mark Brown >> CC: Liam Girdwood >> --- >> drivers/regulator/ti-abb-regulator.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb-regulator.c >> index 870d209..f494a11 100644 >> --- a/drivers/regulator/ti-abb-regulator.c >> +++ b/drivers/regulator/ti-abb-regulator.c >> @@ -722,10 +722,10 @@ static int ti_abb_probe(struct platform_device *pdev) >> ret = -ENODEV; >> goto err; >> } >> - abb->base = devm_request_and_ioremap(dev, res); >> - if (!abb->base) { >> + abb->base = devm_ioremap_resource(dev, res); >> + if (IS_ERR(abb->base)) { >> dev_err(dev, "Unable to map '%s'\n", pname); > > You may remove the above error message as devm_ioremap_resource prints > its own error messages. > There are a few other error messages in the driver (related to devm_ioremap_nocache) in the same format. I would prefer to leave this error message right now. >> - ret = -ENOMEM; >> + ret = PTR_ERR(abb->base); >> goto err; >> } >> >> @@ -776,10 +776,10 @@ static int ti_abb_probe(struct platform_device *pdev) >> ret = -ENODEV; >> goto skip_opt; >> } >> - abb->ldo_base = devm_request_and_ioremap(dev, res); >> - if (!abb->ldo_base) { >> + abb->ldo_base = devm_ioremap_resource(dev, res); >> + if (IS_ERR(abb->ldo_base)) { >> dev_err(dev, "Unable to map '%s'\n", pname); > > ditto > Same as above. Thanks. -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/