Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754355Ab3FKJrB (ORCPT ); Tue, 11 Jun 2013 05:47:01 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:37753 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754228Ab3FKJq7 (ORCPT ); Tue, 11 Jun 2013 05:46:59 -0400 Date: Tue, 11 Jun 2013 02:46:58 -0700 (PDT) Message-Id: <20130611.024658.1499256804576895449.davem@davemloft.net> To: mst@redhat.com Cc: netdev@vger.kernel.org, asias@redhat.com, tt.rantala@gmail.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 2/2] vhost: fix ubuf_info cleanup From: David Miller In-Reply-To: <1370521145-9723-3-git-send-email-mst@redhat.com> References: <1370521145-9723-1-git-send-email-mst@redhat.com> <1370521145-9723-3-git-send-email-mst@redhat.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 674 Lines: 17 From: "Michael S. Tsirkin" Date: Thu, 6 Jun 2013 15:20:46 +0300 > vhost_net_clear_ubuf_info didn't clear ubuf_info > after kfree, this could trigger double free. > Fix this and simplify this code to make it more robust: make sure > ubuf info is always freed through vhost_net_clear_ubuf_info. > > Reported-by: Tommi Rantala > Signed-off-by: Michael S. Tsirkin Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/