Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754466Ab3FKJrR (ORCPT ); Tue, 11 Jun 2013 05:47:17 -0400 Received: from utopia.booyaka.com ([74.50.51.50]:33304 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754401Ab3FKJrP (ORCPT ); Tue, 11 Jun 2013 05:47:15 -0400 Date: Tue, 11 Jun 2013 09:47:13 +0000 (UTC) From: Paul Walmsley To: Prashant Gaikwad cc: Stephen Warren , "linux-tegra@vger.kernel.org" , "mturquette@linaro.org" , Peter De Schrijver , Aleksandr Frid , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/3] clk: tegra: T114: add DFLL DVCO reset control In-Reply-To: <51B6D239.5030905@nvidia.com> Message-ID: References: <20130607121505.21868.72360.stgit@dusk.lan> <20130607121901.21868.65416.stgit@dusk.lan> <51B21105.1080301@wwwdotorg.org> <51B6D239.5030905@nvidia.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 578 Lines: 16 On Tue, 11 Jun 2013, Prashant Gaikwad wrote: > Why not implement these APIs in DFLL clock driver itself and pass RST address > register to driver? The DFLL DVCO reset registers are CAR registers, not DFLL registers. Functions that operate on registers in one IP block shouldn't be located in another IP block's driver. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/