Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754422Ab3FKKE3 (ORCPT ); Tue, 11 Jun 2013 06:04:29 -0400 Received: from mail-ea0-f169.google.com ([209.85.215.169]:44841 "EHLO mail-ea0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704Ab3FKKE2 (ORCPT ); Tue, 11 Jun 2013 06:04:28 -0400 MIME-Version: 1.0 In-Reply-To: References: <1370845742-18919-1-git-send-email-yinghai@kernel.org> Date: Tue, 11 Jun 2013 12:04:26 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] x86, range: Do not add new blank slot with add_range_with_merge From: "Joshua C." To: Yinghai Lu Cc: Sergey Meirovich , "H. Peter Anvin" , Andrew Morton , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1802 Lines: 62 2013/6/11 Joshua C. : > 2013/6/10 Yinghai Lu : >> On Mon, Jun 10, 2013 at 3:55 AM, Sergey Meirovich wrote: >> >>> patches 1,2(latest one) have not helped me on 3.9.5: >> >> So v1: >> https://patchwork.kernel.org/patch/2694981/ >> https://patchwork.kernel.org/patch/2694971/ >> >> and v2: >> https://patchwork.kernel.org/patch/2695891/ >> https://patchwork.kernel.org/patch/2695881/ >> >> Neither of two versions fix the problem on your setup? >> >> Can you post boot log with mtrr_cleanup_debug on 3.9.4? >> >> Thanks >> >> Yinghai > > I got some warnings when trying to build v2 of the patches: > > # make -s ARCH=x86_64 V=1 -j4 bzImage > kernel/range.c: In function 'add_range_with_merge': > kernel/range.c:51:3: error: implicit declaration of function 'memmove' > [-Werror=implicit-function-declaration] > kernel/range.c:51:3: warning: incompatible implicit declaration of > built-in function 'memmove' [enabled by default] > cc1: some warnings being treated as errors > scripts/Makefile.build:307: recipe for target 'kernel/range.o' failed > make[1]: *** [kernel/range.o] Error 1 > Makefile:793: recipe for target 'kernel' failed > make: *** [kernel] Error 2 > make: *** Waiting for unfinished jobs.... > > > -- > --joshua A trivial fix for the above warnings: --- linux-2.6.orig/kernel/range.c +++ linux-2.6/kernel/range.c @@ -4,6 +4,7 @@ #include #include #include +#include #include -- --joshua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/