Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754817Ab3FKLKn (ORCPT ); Tue, 11 Jun 2013 07:10:43 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:62226 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754794Ab3FKLKl (ORCPT ); Tue, 11 Jun 2013 07:10:41 -0400 Message-ID: <51B705AD.3040803@cogentembedded.com> Date: Tue, 11 Jun 2013 15:10:37 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Philip Avinash CC: Sekhar Nori , davinci-linux-open-source@linux.davincidsp.com, linux@arm.linux.org.uk, khilman@deeprootsystems.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/11] ARM: davinci: GPIO: Add platform data structure References: <1369206634-6778-1-git-send-email-avinashphilip@ti.com> <1369206634-6778-2-git-send-email-avinashphilip@ti.com> <51B6FDA2.8080003@ti.com> In-Reply-To: <51B6FDA2.8080003@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2013 Lines: 63 Hello. On 11-06-2013 14:36, Sekhar Nori wrote: >> From: KV Sujith >> Add struct davinci_gpio_platform_data davinci gpio module. >> Signed-off-by: KV Sujith >> Signed-off-by: Philip Avinash > As Linus commented before, this should be merged with 03/11. >> --- >> include/linux/platform_data/gpio-davinci.h | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> create mode 100644 include/linux/platform_data/gpio-davinci.h >> diff --git a/include/linux/platform_data/gpio-davinci.h b/include/linux/platform_data/gpio-davinci.h >> new file mode 100644 >> index 0000000..f1c8277 >> --- /dev/null >> +++ b/include/linux/platform_data/gpio-davinci.h >> @@ -0,0 +1,27 @@ >> +/* >> + * gpio-davinci.h > > I would drop this unnecessary filename mention as well. > >> + * >> + * DaVinci GPIO Platform Related Defines >> + * >> + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/ >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation version 2. >> + * >> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any >> + * kind, whether express or implied; without even the implied warranty >> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> + >> +#ifndef __ASM_ARCH_DAVINCI_GPIO_H >> +#define __ASM_ARCH_DAVINCI_GPIO_H > This should now be __PLATFORM_DATA_DAVINCI_GPIO_H__ or some such since > the file as been moved out of arch specific folder. I think __GPIO_DAVINCI_H would be enough... > Thanks, > Sekhar WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/