Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754843Ab3FKLK6 (ORCPT ); Tue, 11 Jun 2013 07:10:58 -0400 Received: from mail-ea0-f178.google.com ([209.85.215.178]:32913 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754794Ab3FKLKz (ORCPT ); Tue, 11 Jun 2013 07:10:55 -0400 Date: Tue, 11 Jun 2013 12:10:50 +0100 From: Lee Jones To: Ulf Hansson Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, Mike Turquette Subject: Re: [PATCH 19/33] clk: ux500: Add Device Tree support for the PRCMU clock Message-ID: <20130611111050.GC3330@laptop> References: <1370521041-32318-1-git-send-email-lee.jones@linaro.org> <1370521041-32318-20-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1954 Lines: 52 On Mon, 10 Jun 2013, Ulf Hansson wrote: > On 6 June 2013 14:17, Lee Jones wrote: > > This patch enables clocks to be specified from Device Tree via phandles > > to the "prcmu-clock" node. > > > > Cc: Mike Turquette > > Cc: Ulf Hansson > > Signed-off-by: Lee Jones > > --- > > drivers/clk/ux500/u8500_clk.c | 50 +++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 48 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/clk/ux500/u8500_clk.c b/drivers/clk/ux500/u8500_clk.c > > index 3a7040b..4f5ad4c 100644 > > --- a/drivers/clk/ux500/u8500_clk.c > > +++ b/drivers/clk/ux500/u8500_clk.c > > @@ -15,6 +15,8 @@ > > #include > > #include "clk.h" > > > > +static struct clk *prcmu_clk[PRCMU_NUM_CLKS]; > > + > > struct clk *ux500_twocell_get(struct of_phandle_args *clkspec, void *data) > > Actually I thought ux500_twocell_get was going to be used in this > patch, since the previous one was adding this helper function, but it > isn't? Yes it is: > > for_each_child_of_node(np, child) { > > - /* Place holder for supported nodes. */ > > + static struct clk_onecell_data clk_data; > > + > > + if (!of_node_cmp(child->name, "prcmu-clock")) { > > + clk_data.clks = prcmu_clk; > > + clk_data.clk_num = ARRAY_SIZE(prcmu_clk); > > + of_clk_add_provider(child, of_clk_src_onecell_get, &clk_data); Here. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/