Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754025Ab3FKOX4 (ORCPT ); Tue, 11 Jun 2013 10:23:56 -0400 Received: from mga03.intel.com ([143.182.124.21]:26013 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585Ab3FKOXy (ORCPT ); Tue, 11 Jun 2013 10:23:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,845,1363158000"; d="scan'208";a="315349027" Date: Tue, 11 Jun 2013 16:23:47 +0200 From: Samuel Ortiz To: Sebastian Andrzej Siewior Cc: Lee Jones , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Jonathan Cameron , Dmitry Torokhov , Felipe Balbi , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, "Patil, Rachna" , Pantelis Antoniou Subject: Re: [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support Message-ID: <20130611142347.GF29135@zurbaran> References: <1370950268-7224-1-git-send-email-bigeasy@linutronix.de> <1370950268-7224-11-git-send-email-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1370950268-7224-11-git-send-email-bigeasy@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 35 Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:56PM +0200, Sebastian Andrzej Siewior wrote: > From: "Patil, Rachna" > > Make changes to add DT support in the MFD core driver. Which changes ? > [ panto@antoniou-consulting.com : use of_get_child_by_name > instead of of_find_node_by_name ] I have no idea where that is coming from. Please remove this kind of stuff and build a proper commit log instead. > Signed-off-by: Pantelis Antoniou > Signed-off-by: Patil, Rachna > Signed-off-by: Felipe Balbi > [bigeasy: module alias, rename to ti,am3359-tscadc as it was tested on > AM3359] I honestly can't tell if this is a change from the last version of your patchset or a description of this patch changes in general. This is cluttering your commit logs, please remove this as well. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/