Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753814Ab3FKPOy (ORCPT ); Tue, 11 Jun 2013 11:14:54 -0400 Received: from a9-50.smtp-out.amazonses.com ([54.240.9.50]:57982 "EHLO a9-50.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343Ab3FKPOx (ORCPT ); Tue, 11 Jun 2013 11:14:53 -0400 Date: Tue, 11 Jun 2013 15:14:51 +0000 From: Christoph Lameter To: Sasha Levin cc: Pekka Enberg , "linux-mm@kvack.org" , Andrew Morton , LKML Subject: Re: [PATCH] slab: prevent warnings when allocating with __GFP_NOWARN In-Reply-To: <51B72323.8040207@oracle.com> Message-ID: <0000013f33cdc631-eadb07d1-ef08-4e2c-a218-1997eb86cde9-000000@email.amazonses.com> References: <1370891880-2644-1-git-send-email-sasha.levin@oracle.com> <51B62F6B.8040308@oracle.com> <0000013f3075f90d-735942a8-b4b8-413f-a09e-57d1de0c4974-000000@email.amazonses.com> <51B67553.6020205@oracle.com> <51B72323.8040207@oracle.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SES-Outgoing: 2013.06.11-54.240.9.50 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 16 On Tue, 11 Jun 2013, Sasha Levin wrote: > I think that leaving the warning makes sense to catch similar > things which are actually bugs - we had a similar issue with > /dev/kmsg (if I remember correctly) which actually pointed to > a bug. Right. Requesting an allocation larger than even supported by the page allocator from the slab allocators that are specializing in allocations of small objects is usually an indication of a problem in the code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/