Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755256Ab3FKQ3d (ORCPT ); Tue, 11 Jun 2013 12:29:33 -0400 Received: from mail.windriver.com ([147.11.1.11]:48664 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168Ab3FKQ3c (ORCPT ); Tue, 11 Jun 2013 12:29:32 -0400 Message-ID: <51B75088.8050800@windriver.com> Date: Tue, 11 Jun 2013 12:30:00 -0400 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Markos Chandras CC: , "David S. Miller" , Subject: Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX References: <1370962642-12097-1-git-send-email-markos.chandras@imgtec.com> In-Reply-To: <1370962642-12097-1-git-send-email-markos.chandras@imgtec.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.146.65] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1706 Lines: 46 On 13-06-11 10:57 AM, Markos Chandras wrote: > The Vortex driver depends on PCI with optional support for EISA. > > This fixes build problems when EISA is selected but not PCI. > > drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of > function 'pci_iomap' [-Werror=implicit-function-declaration] > drivers/net/ethernet/3com/3c59x.c:1044:3: error: implicit declaration of > function 'pci_iounmap' [-Werror=implicit-function-declaration] > > Cc: David S. Miller > Cc: Paul Gortmaker > Cc: netdev@vger.kernel.org > Signed-off-by: Markos Chandras > --- > drivers/net/ethernet/3com/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/3com/Kconfig b/drivers/net/ethernet/3com/Kconfig > index 1c71c76..5c67f44 100644 > --- a/drivers/net/ethernet/3com/Kconfig > +++ b/drivers/net/ethernet/3com/Kconfig > @@ -66,7 +66,7 @@ config PCMCIA_3C589 > > config VORTEX > tristate "3c590/3c900 series (592/595/597) \"Vortex/Boomerang\" support" > - depends on (PCI || EISA) && HAS_IOPORT > + depends on PCI && HAS_IOPORT How can this fix it? The way I read your change is that you have now made it impossible to select for EISA=y and PCI=n, thus breaking EISA only configurations who would find their driver support gone when they run "make oldconfig". P. -- > select NET_CORE > select MII > ---help--- > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/