Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756065Ab3FKSaF (ORCPT ); Tue, 11 Jun 2013 14:30:05 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:38036 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430Ab3FKSaE (ORCPT ); Tue, 11 Jun 2013 14:30:04 -0400 MIME-Version: 1.0 In-Reply-To: References: <1370845742-18919-1-git-send-email-yinghai@kernel.org> Date: Tue, 11 Jun 2013 11:30:03 -0700 X-Google-Sender-Auth: FdsbMxdcgpWGzid8TsyW_mWGRz8 Message-ID: Subject: Re: [PATCH v2 2/2] x86, range: Do not add new blank slot with add_range_with_merge From: Yinghai Lu To: "Joshua C." , Andrew Morton , "H. Peter Anvin" Cc: Sergey Meirovich , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2885 Lines: 90 On Tue, Jun 11, 2013 at 10:08 AM, Joshua C. wrote: > 2013/6/11 Yinghai Lu : >> On Tue, Jun 11, 2013 at 3:04 AM, Joshua C. wrote: >>> 2013/6/11 Joshua C. : >>>> 2013/6/10 Yinghai Lu : >>>>> On Mon, Jun 10, 2013 at 3:55 AM, Sergey Meirovich wrote: >>>>> >>>>>> patches 1,2(latest one) have not helped me on 3.9.5: >>>>> >>>>> So v1: >>>>> https://patchwork.kernel.org/patch/2694981/ >>>>> https://patchwork.kernel.org/patch/2694971/ >>>>> >>>>> and v2: >>>>> https://patchwork.kernel.org/patch/2695891/ >>>>> https://patchwork.kernel.org/patch/2695881/ >>>>> >>>>> Neither of two versions fix the problem on your setup? >>>>> >>>>> Can you post boot log with mtrr_cleanup_debug on 3.9.4? >>>>> >>>>> Thanks >>>>> >>>>> Yinghai >>>> >>>> I got some warnings when trying to build v2 of the patches: >>>> >>>> # make -s ARCH=x86_64 V=1 -j4 bzImage >>>> kernel/range.c: In function 'add_range_with_merge': >>>> kernel/range.c:51:3: error: implicit declaration of function 'memmove' >>>> [-Werror=implicit-function-declaration] >>>> kernel/range.c:51:3: warning: incompatible implicit declaration of >>>> built-in function 'memmove' [enabled by default] >>>> cc1: some warnings being treated as errors >>>> scripts/Makefile.build:307: recipe for target 'kernel/range.o' failed >>>> make[1]: *** [kernel/range.o] Error 1 >>>> Makefile:793: recipe for target 'kernel' failed >>>> make: *** [kernel] Error 2 >>>> make: *** Waiting for unfinished jobs.... >>>> >>>> >>>> -- >>>> --joshua >> >> it does not report warning when I compile it with >> >> gcc (SUSE Linux) 4.7.2 20130108 [gcc-4_7-branch revision 195012 >> >>> >>> A trivial fix for the above warnings: >>> >>> --- linux-2.6.orig/kernel/range.c >>> +++ linux-2.6/kernel/range.c >>> @@ -4,6 +4,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #include >>> > > I use fedora17 with gcc version 4.7.3 (git checkout on 20130411). I > have no idea where this came from... Ok. Your config should have CONFIG_DYNAMIC_DEBUG defined, and my config does not have that defined. we have linux/kernel.h linux/printk.h linux/dynamic_debug.h dynamic_debug.h will include linux/string.h when CONFIG_DYNAMIC_DEBUG is not defined. Hi, Andrew, How to fix this inconsistency caused by dynamic_debug.h 1. let linux/kernel.h include string.h directly 2. or let dynamic_debug include string.h always 3. let printk.h include string.h. ... Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/