Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756019Ab3FKUAq (ORCPT ); Tue, 11 Jun 2013 16:00:46 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41567 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755370Ab3FKUAo (ORCPT ); Tue, 11 Jun 2013 16:00:44 -0400 Date: Tue, 11 Jun 2013 13:00:42 -0700 From: Andrew Morton To: Jiang Liu Cc: Jiang Liu , David Rientjes , Wen Congyang , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , James Bottomley , Sergei Shtylyov , David Howells , Mark Salter , Jianguo Wu , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Michel Lespinasse , Rik van Riel Subject: Re: [PATCH v8, part3 10/14] mm: use a dedicated lock to protect totalram_pages and zone->managed_pages Message-Id: <20130611130042.3dec2cc6737f21180bc09bb1@linux-foundation.org> In-Reply-To: <1369575522-26405-11-git-send-email-jiang.liu@huawei.com> References: <1369575522-26405-1-git-send-email-jiang.liu@huawei.com> <1369575522-26405-11-git-send-email-jiang.liu@huawei.com> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1768 Lines: 46 On Sun, 26 May 2013 21:38:38 +0800 Jiang Liu wrote: > Currently lock_memory_hotplug()/unlock_memory_hotplug() are used to > protect totalram_pages and zone->managed_pages. Other than the memory > hotplug driver, totalram_pages and zone->managed_pages may also be > modified at runtime by other drivers, such as Xen balloon, > virtio_balloon etc. For those cases, memory hotplug lock is a little > too heavy, so introduce a dedicated lock to protect totalram_pages > and zone->managed_pages. > > Now we have a simplified locking rules totalram_pages and > zone->managed_pages as: > 1) no locking for read accesses because they are unsigned long. > 2) no locking for write accesses at boot time in single-threaded context. > 3) serialize write accesses at runtime by acquiring the dedicated > managed_page_count_lock. > > Also adjust zone->managed_pages when freeing reserved pages into the > buddy system, to keep totalram_pages and zone->managed_pages in > consistence. > > ... > > +void adjust_managed_page_count(struct page *page, long count) > +{ > + spin_lock(&managed_page_count_lock); > + page_zone(page)->managed_pages += count; > + totalram_pages += count; > + spin_unlock(&managed_page_count_lock); > +} > +EXPORT_SYMBOL(adjust_managed_page_count); This is exported to modules but there are no modular callers at this time. I assume this was done for some forthcoming xen/virtio_balloon/etc patches? If so, it would be better to avoid adding the export until it is actually needed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/