Message-ID: <1370981396.9844.219.camel@gandalf.local.home>
Subject: Re: [PATCH RFC ticketlock] Auto-queued ticketlock
From: Steven Rostedt <rostedt@goodmis.org>
To: paulmck@linux.vnet.ibm.com
Cc: Waiman Long <waiman.long@hp.com>, linux-kernel@vger.kernel.org,
        mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
        akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
        josh@joshtriplett.org, niv@us.ibm.com, tglx@linutronix.de,
        peterz@infradead.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
        edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com,
        sbw@mit.edu, torvalds@linux-foundation.org,
        Davidlohr Bueso <davidlohr.bueso@hp.com>
Date: Tue, 11 Jun 2013 16:09:56 -0400
In-Reply-To: <20130611194927.GX5146@linux.vnet.ibm.com>
References: <20130609193657.GA13392@linux.vnet.ibm.com>
	 <51B748DA.2070306@hp.com> <20130611163607.GG5146@linux.vnet.ibm.com>
	 <51B76F77.6020004@hp.com> <20130611194927.GX5146@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1771
Lines: 60

On Tue, 2013-06-11 at 12:49 -0700, Paul E. McKenney wrote:

> +bool tkt_spin_pass(arch_spinlock_t *ap, struct __raw_tickets inc)
> +{
> +	if (unlikely(inc.head & 0x1)) {
> +
> +		/* This lock has a queue, so go spin on the queue. */
> +		if (tkt_q_do_spin(ap, inc))
> +			return true;
> +
> +		/* Get here if the queue is in transition: Retry next time. */
> +

This looks better, but please add a comment, something to the likes of:

	/*
	 * Only the TKT_Q_SWITCH waiter will set up the queue to prevent
	 * a thundering herd of setups to occur. It is still possible for
	 * more than one task to perform a setup if the lock is released
	 * after this check, a waiter coming in may also match this test. But
	 * that's covered by the cmpxchg() setup in tkt_q_start_contend.
	 */


> +	} else if (inc.tail - TKT_Q_SWITCH == inc.head) {

Also shouldn't this be:

	} else if ((__ticket_t)(inc.tail - TKT_Q_SWITCH) == inc.head) {

As TKT_Q_SWITCH doesn't have a type, I'm not sure how C will evaluate
this. I always screw type conversions up, and just add in the type casts
to be safe.

You could also give TKT_Q_SWITCH a type too.

-- Steve

> +
> +		/*
> +		 * This lock has lots of spinners, but no queue.
> +		 * Go create a queue to spin on.
> +		 */
> +		if (tkt_q_start_contend(ap, inc))
> +			return true;
> +
> +		/* Get here if the queue is in transition: Retry next time. */
> +	}
> +
> +	/* Either no need for a queue or the queue is in transition.  Spin. */
> +	return false;
> +}
> +EXPORT_SYMBOL(tkt_spin_pass);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/