Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754924Ab3FLM4O (ORCPT ); Wed, 12 Jun 2013 08:56:14 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:63058 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753814Ab3FLM4L (ORCPT ); Wed, 12 Jun 2013 08:56:11 -0400 From: Grant Likely Subject: Re: [PATCH 21/21] clk: ux500: Supply provider look-up functionality to support Device Tree To: Linus Walleij , Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Ulf Hansson , Mike Turquette , "devicetree-discuss@lists.ozlabs.org" In-Reply-To: References: <1370266965-7901-1-git-send-email-lee.jones@linaro.org> <1370266965-7901-22-git-send-email-lee.jones@linaro.org> Date: Wed, 12 Jun 2013 13:56:07 +0100 Message-Id: <20130612125607.5C13E3E0A56@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1558 Lines: 32 On Tue, 4 Jun 2013 12:57:06 +0200, Linus Walleij wrote: > On Mon, Jun 3, 2013 at 3:42 PM, Lee Jones wrote: > > > In this patch we're populating a clk_data array, one clock per element to > > act as a clk look-up using indexes supplied from Device Tree. > > > > Cc: Mike Turquette > > Signed-off-by: Lee Jones > > This needs to be patch 1/21 because otherwise the rest of the > stuff is non-bisectable right? It's being broken the first time > you remove auxdata and not fixed until this patch. > > The whole thing is very different from other DT clock things > I've seen, usually you add a compatible node for each > clock type, and a node for each physical gate. But there > may be several ways to skin this cat... The design choice made here is perfectly fine by me. There has never been a requirement to expose every clock as a separate node, and for SoCs with complex clock control blocks I can certainly appreciate not wanting to expose how the internal clocks interact out to the device tree, especially if only the leaf clocks ever get reverenced by device drivers. As long as there is a driver there that understands the binding and hands out the correct clock when asked, then this design is great. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/