USER-AGENT: Mutt/1.5.21 (2010-09-15)
MIME-Version: 1.0
Message-ID: <20130612150817.GA12624@mwanda>
Date: Wed, 12 Jun 2013 08:08:17 -0700 (PDT)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: omar.ramirez@copitl.com, gregkh@linuxfoundation.org,
        justinmattock@gmail.com, andriy.shevchenko@linux.intel.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: tidspbridge: Fix potential NULL pointer
 dereference
References: <1371047595-11702-1-git-send-email-emilgoode@gmail.com>
In-Reply-To: <1371047595-11702-1-git-send-email-emilgoode@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 716
Lines: 19

1) This patch doesn't do anything.  "dcd_key" points to freed memory
but it's not a NULL pointer.
2) The original pointer doesn't dereference "dcd_key" it just takes
the address of one of the elements.  I don't know the context and
can't say for sure that it's a wrong thing to do.

The code does look very suspect.  Why is it checking permisions
after we already removed the element and freed it?

But it's not a dereferencing freed memory bug.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/