Message-ID: <51B8BA92.2090801@zytor.com>
Date: Wed, 12 Jun 2013 11:14:42 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
MIME-Version: 1.0
To: Yinghai Lu <yinghai@kernel.org>
CC: Kees Cook <keescook@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        David Woodhouse <David.Woodhouse@intel.com>,
        Matt Fleming <matt.fleming@intel.com>,
        Alexander Duyck <alexander.h.duyck@intel.com>,
        Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH] x86, relocs: move ELF relocation handling to C
References: <20130611185846.GA23707@www.outflux.net> <CAE9FiQXgO+yScU2cBazJtX2mFHRMv=wObrTjpFvW5ajFNjBvCA@mail.gmail.com>
In-Reply-To: <CAE9FiQXgO+yScU2cBazJtX2mFHRMv=wObrTjpFvW5ajFNjBvCA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 845
Lines: 30

On 06/12/2013 11:13 AM, Yinghai Lu wrote:
> 
> it seems those lines for x86_64 are never used.
> as X86_NEED_RELOCS is not defined for x86_64
> 
>>  config X86_NEED_RELOCS
>>         def_bool y
>>         depends on X86_32 && RELOCATABLE
> 
> 
>> +}
>> +#else
>> +static inline void handle_relocations(void *output, unsigned long output_len)
>> +{ }
>> +#endif
> 
> Can you make it clear that this patch only affect x86_32 in patch title?
> 

I am not sure this belongs in the patch title, as it is preparatory work
for x86-64.  It should be mentioned in the patch description body, though.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/