Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932266Ab3FMBUh (ORCPT ); Wed, 12 Jun 2013 21:20:37 -0400 Received: from intranet.asianux.com ([58.214.24.6]:53455 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756833Ab3FMBUg (ORCPT ); Wed, 12 Jun 2013 21:20:36 -0400 X-Spam-Score: -100.8 Message-ID: <51B91E32.2040502@asianux.com> Date: Thu, 13 Jun 2013 09:19:46 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Heiko Carstens CC: Bjorn Helgaas , Mike Frysinger , takata@linux-m32r.org, Martin Schwidefsky , Arnd Bergmann , realmz paranoid , linux390@de.ibm.com, "uclinux-dist-devel@blackfin.uclinux.org" , "linux-kernel@vger.kernel.org" , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, linux-s390@vger.kernel.org, Linux-Arch , Marc Gauthier Subject: Re: [PATCH v2] arch: asm-generic: for atomic_set_mask() 1st param, use 'unsigned int' instead of 'unsigned long' References: <51B2E262.3030603@asianux.com> <51B4214E.6090007@asianux.com> <20130610092106.GA4697@osiris> In-Reply-To: <20130610092106.GA4697@osiris> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 39 On 06/10/2013 05:21 PM, Heiko Carstens wrote: > On Sun, Jun 09, 2013 at 02:31:42PM +0800, Chen Gang wrote: >> > >> > atomic_set_mask() and atomic_clear_mask() are the pairs, so the related >> > parameters' type need match with each other. >> > >> > The type of 'addr->counter' is 'int', so use 'unsigned int' instead >> > of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask(). >> > >> > >> > For arch sub-system, currently, have 3 types of definition for them: >> > 1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'. >> > >> > At least, better to fix 3rd (conflict using 'int' and 'long'). >> > >> > Signed-off-by: Chen Gang >> > --- >> > arch/blackfin/include/asm/atomic.h | 4 ++-- >> > arch/m32r/include/asm/atomic.h | 8 ++++---- >> > arch/s390/include/asm/atomic.h | 4 ++-- >> > include/asm-generic/atomic.h | 2 +- >> > 4 files changed, 9 insertions(+), 9 deletions(-) > For the s390 part: > > Acked-by: Heiko Carstens > Thank you very much !! -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/