Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758284Ab3FMCwI (ORCPT ); Wed, 12 Jun 2013 22:52:08 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34652 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758233Ab3FMCwG (ORCPT ); Wed, 12 Jun 2013 22:52:06 -0400 Date: Wed, 12 Jun 2013 19:52:02 -0700 From: Kent Overstreet To: Tejun Heo Cc: Li Zefan , containers@lists.linux-foundation.org, Cgroups , lkml , Christoph Lameter Subject: Re: [PATCH 04/11] cgroup: use kzalloc() and list_del_init() Message-ID: <20130613025202.GD10979@localhost> References: <1371070996-20613-1-git-send-email-tj@kernel.org> <1371070996-20613-5-git-send-email-tj@kernel.org> <51B93038.9010202@huawei.com> <20130613023831.GB10979@localhost> <20130613024310.GC10979@localhost> <20130613024859.GA7432@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130613024859.GA7432@mtj.dyndns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 953 Lines: 19 On Wed, Jun 12, 2013 at 07:48:59PM -0700, Tejun Heo wrote: > On Wed, Jun 12, 2013 at 07:43:10PM -0700, Kent Overstreet wrote: > > list_del() does do poisoning - and list debugging is cheaper to enable > > than full slab debugging. > > Ah, right, now we have DEBUG_LIST. Completely forgot about that. I > don't think the cost difference matters that much as long as there are > enough people running with slab debugging, but, yeah, with DEBUG_LIST, > leaving list_del() alone would actually be better. I'll drop that > part. I can't remember if it was Fedora or RH (or both?) but in one of those they actually leave it enabled in their production kernels. Someone was blogging about the bugs it found... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/