Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758549Ab3FMJTq (ORCPT ); Thu, 13 Jun 2013 05:19:46 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:56487 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758532Ab3FMJTp (ORCPT ); Thu, 13 Jun 2013 05:19:45 -0400 From: "Philip, Avinash" To: "Nori, Sekhar" CC: "khilman@deeprootsystems.com" , "linux@arm.linux.org.uk" , "grant.likely@secretlab.ca" , "linus.walleij@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 03/11] gpio: davinci: Modify to platform driver Thread-Topic: [PATCH 03/11] gpio: davinci: Modify to platform driver Thread-Index: AQHOVrtf6gwEFoq/8kygHsiS/vHYRpkwAbsAgACPoZCAALxDgIAAxFyQgAC16gCAAItCwP//maCAgACH+5A= Date: Thu, 13 Jun 2013 09:18:01 +0000 Deferred-Delivery: Thu, 13 Jun 2013 09:17:00 +0000 Message-ID: <518397C60809E147AF5323E0420B992E3EADA96F@DBDE04.ent.ti.com> References: <1369206634-6778-1-git-send-email-avinashphilip@ti.com> <1369206634-6778-4-git-send-email-avinashphilip@ti.com> <51B71056.9010103@ti.com> <518397C60809E147AF5323E0420B992E3EAD9D75@DBDE04.ent.ti.com> <51B826BF.7050009@ti.com> <518397C60809E147AF5323E0420B992E3EADA252@DBDE04.ent.ti.com> <51B96410.7000807@ti.com> <518397C60809E147AF5323E0420B992E3EADA883@DBDE04.ent.ti.com> <51B98301.9090404@ti.com> In-Reply-To: <51B98301.9090404@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r5D9Js7s027920 Content-Length: 3430 Lines: 107 On Thu, Jun 13, 2013 at 13:59:53, Nori, Sekhar wrote: > On 6/13/2013 1:02 PM, Philip, Avinash wrote: > > > With tnetv107x_defconfig build is failing > > > > arch/arm/mach-davinci/board-tnetv107x-evm.c:282:15: error: > > 'davinci_timer_init' undeclared here (not in a function) > > arch/arm/mach-davinci/board-tnetv107x-evm.c:284:15: error: > > 'davinci_init_late' undeclared here (not in a function) > > make[1]: *** [arch/arm/mach-davinci/board-tnetv107x-evm.o] Error 1 > > > > Following patch fixes the build above breakage > > The error you are seeing and the patch you provided below have no > correlation. No. Above build error fixed by +#include Other changes are not related to above error. > > > > > diff --git a/arch/arm/mach-davinci/board-tnetv107x-evm.c b/arch/arm/mach-davinci/board-tnetv107x-evm.c > > index ba79837..4a9c320 100644 > > --- a/arch/arm/mach-davinci/board-tnetv107x-evm.c > > +++ b/arch/arm/mach-davinci/board-tnetv107x-evm.c > > @@ -30,6 +30,7 @@ > > #include > > #include > > > > +#include > > #include > > #include > > #include > > @@ -147,7 +148,7 @@ static struct davinci_nand_pdata nand_config = { > > .ecc_bits = 1, > > }; > > > > -static struct davinci_uart_config serial_config __initconst = { > > +static struct davinci_uart_config serial_config = { > > .enabled_uarts = BIT(1), > > }; > > You can make this __initdata instead - assuming its okay to have this > memory discarded at init. I will check. > > > > > @@ -245,7 +246,7 @@ static struct ti_ssp_data ssp_config = { > > }, > > }; > > > > -static struct tnetv107x_device_info evm_device_info __initconst = { > > +static struct tnetv107x_device_info evm_device_info = { > > Same here. You can make this __initdata. > > Please send a formal patch for the errors you have seen. Ok > > > .serial_config = &serial_config, > > .mmc_config[1] = &mmc_config, /* controller 1 */ > > .nand_config[0] = &nand_config, /* chip select 0 */ > > > > > > > >> > >>> > >>> So I prefer to leave tnetv107x platform for now. > >> > >> I don't think that's acceptable. At least by me. > > > > I think 2 options are available > > 1. Convert gpio-tnetv107x.c to platform driver. This will help in > > removing gpio references in davinci_soc_info structure. > > 2. Remove inline gpio api support and start use gpiolib support. > > > > I prefer first option. It will help in removing > > . > > Okay. Can you take this up in this series? I understand you may not have > an tnetv107x board, but at least you can get to a series that builds. > > Even if you choose to do just option #2, I am OK. What I really want to > see is inline API gone completely (not just remain largely unused). This > will also help you avoid exposing internal data structures like > davinci_gpio_controller exposed to the whole kernel. The worse part > right now is you have two copies of the same structure exposed globally > from two different include folders. I understood. I will take option 2. Thanks Avinash > > Thanks, > Sekhar > ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?