Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754966Ab3FMLzj (ORCPT ); Thu, 13 Jun 2013 07:55:39 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:35983 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406Ab3FMLzh (ORCPT ); Thu, 13 Jun 2013 07:55:37 -0400 From: "Rafael J. Wysocki" To: Yinghai Lu Cc: Bjorn Helgaas , Jiang Liu , Roman Yepishev , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Torvalds , Andrew Morton , Greg Kroah-Hartman Subject: Re: [PATCH] PCI: Remove not needed check in disable aspm link Date: Thu, 13 Jun 2013 14:04:46 +0200 Message-ID: <5579473.Q0gAQnMCR1@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0-rc5+; KDE/4.9.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1405 Lines: 33 On Wednesday, June 12, 2013 10:47:08 PM Yinghai Lu wrote: > On Wed, Jun 12, 2013 at 8:50 PM, Bjorn Helgaas wrote: > > On Wed, Jun 12, 2013 at 1:41 PM, Yinghai Lu wrote: > > > > I think you're saying that in systems that support both acpiphp and > > pciehp, we should be using pciehp, but we currently use acpiphp. If > > so, that's certainly a bug. How serious is it? Is it a disaster if > > we use acpiphp until we can resolve this cleanly? Are there a lot of > > systems that claim to support acpiphp but it doesn't actually work? > > No sure. To make acpiphp would need more expertise in bios. > Normally BIOS vendor would have half done work there, and will need > OEM or system vendor have someone to make it work .... > You would not want to read asl code in DSDT to help them out. > That is not something that we can control. However, pciehp may simply not work by itself on those systems. It's pretty much like saying "Oh, _CRS may be screwed up, so let's just ignore it", which isn't overly smart. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/