Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756557Ab3FMMer (ORCPT ); Thu, 13 Jun 2013 08:34:47 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:60415 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754183Ab3FMMeq (ORCPT ); Thu, 13 Jun 2013 08:34:46 -0400 MIME-Version: 1.0 In-Reply-To: <1371058399-31933-3-git-send-email-dianders@chromium.org> References: <1371058399-31933-1-git-send-email-dianders@chromium.org> <1371058399-31933-3-git-send-email-dianders@chromium.org> Date: Thu, 13 Jun 2013 14:34:45 +0200 Message-ID: Subject: Re: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking From: Linus Walleij To: Doug Anderson Cc: Kukjin Kim , Tomasz Figa , Olof Johansson , Simon Glass , Luigi Semenzato , ilho215.lee@samsung.com, Eunki Kim , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 758 Lines: 19 On Wed, Jun 12, 2013 at 7:33 PM, Doug Anderson wrote: > A level-triggered interrupt should be acked after the interrupt line > becomes inactive and before it is unmasked, or else another interrupt > will be immediately triggered. Acking before or after calling the > handler is not enough. > > Signed-off-by: Luigi Semenzato > Signed-off-by: Doug Anderson I'm holding this off until Tomasz' comments are addressed. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/