Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758605Ab3FMQoQ (ORCPT ); Thu, 13 Jun 2013 12:44:16 -0400 Received: from mail-ee0-f52.google.com ([74.125.83.52]:33795 "EHLO mail-ee0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754633Ab3FMQoO (ORCPT ); Thu, 13 Jun 2013 12:44:14 -0400 From: Tomasz Figa To: Doug Anderson Cc: Linus Walleij , Kukjin Kim , Olof Johansson , Simon Glass , Luigi Semenzato , ilho215.lee@samsung.com, eunki_kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking Date: Thu, 13 Jun 2013 18:44:11 +0200 Message-ID: <2132357.TpKeOTlAXO@flatron> User-Agent: KMail/4.10.4 (Linux/3.9.5-gentoo; KDE/4.10.4; x86_64; ; ) In-Reply-To: <1371141522-29255-3-git-send-email-dianders@chromium.org> References: <1371058399-31933-1-git-send-email-dianders@chromium.org> <1371141522-29255-3-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2503 Lines: 73 On Thursday 13 of June 2013 09:38:42 Doug Anderson wrote: > A level-triggered interrupt should be acked after the interrupt line > becomes inactive and before it is unmasked, or else another interrupt > will be immediately triggered. Acking before or after calling the > handler is not enough. > > Signed-off-by: Luigi Semenzato > Signed-off-by: Doug Anderson > --- > Changes in v2: > - Greatly simplified using Tomasz's suggestion of irqd_get_trigger_type > - Moved acking out of the bank spinlock since since it's not needed. > - Linus W. has already applied parts 1 and 2, so not resending. > > drivers/pinctrl/pinctrl-exynos.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) Looks good. Thanks. Acked-by: Tomasz Figa Best regards, Tomasz > diff --git a/drivers/pinctrl/pinctrl-exynos.c > b/drivers/pinctrl/pinctrl-exynos.c index c0729a3..ef75321 100644 > --- a/drivers/pinctrl/pinctrl-exynos.c > +++ b/drivers/pinctrl/pinctrl-exynos.c > @@ -84,6 +84,17 @@ static void exynos_gpio_irq_unmask(struct irq_data > *irqd) unsigned long mask; > unsigned long flags; > > + /* > + * Ack level interrupts right before unmask > + * > + * If we don't do this we'll get a double-interrupt. Level triggered > + * interrupts must not fire an interrupt if the level is not > + * _currently_ active, even if it was active while the interrupt was > + * masked. > + */ > + if (irqd_get_trigger_type(irqd) & IRQ_TYPE_LEVEL_MASK) > + exynos_gpio_irq_ack(irqd); > + > spin_lock_irqsave(&bank->slock, flags); > > mask = readl(d->virt_base + reg_mask); > @@ -302,6 +313,17 @@ static void exynos_wkup_irq_unmask(struct irq_data > *irqd) unsigned long mask; > unsigned long flags; > > + /* > + * Ack level interrupts right before unmask > + * > + * If we don't do this we'll get a double-interrupt. Level triggered > + * interrupts must not fire an interrupt if the level is not > + * _currently_ active, even if it was active while the interrupt was > + * masked. > + */ > + if (irqd_get_trigger_type(irqd) & IRQ_TYPE_LEVEL_MASK) > + exynos_wkup_irq_ack(irqd); > + > spin_lock_irqsave(&b->slock, flags); > > mask = readl(d->virt_base + reg_mask); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/