Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758826Ab3FMSPR (ORCPT ); Thu, 13 Jun 2013 14:15:17 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:44547 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754414Ab3FMSPP (ORCPT ); Thu, 13 Jun 2013 14:15:15 -0400 MIME-Version: 1.0 In-Reply-To: <20130529222955.10627.50429.stgit@bhelgaas-glaptop> References: <20130529222955.10627.50429.stgit@bhelgaas-glaptop> From: Bjorn Helgaas Date: Thu, 13 Jun 2013 12:14:54 -0600 Message-ID: Subject: Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free To: Alexander Viro , Kent Overstreet Cc: Jens Axboe , linux-fsdevel , "linux-kernel@vger.kernel.org" , "Martin K. Petersen" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1254 Lines: 34 On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas wrote: > This fixes a copy and paste error introduced by 9f060e2231 > ("block: Convert integrity to bvec_alloc_bs()"). > > Found by Coverity (CID 1020654). > > Signed-off-by: Bjorn Helgaas > --- > fs/bio-integrity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c > index 8fb4291..45e944f 100644 > --- a/fs/bio-integrity.c > +++ b/fs/bio-integrity.c > @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs) > mempool_destroy(bs->bio_integrity_pool); > > if (bs->bvec_integrity_pool) > - mempool_destroy(bs->bio_integrity_pool); > + mempool_destroy(bs->bvec_integrity_pool); > } > EXPORT_SYMBOL(bioset_integrity_free); Kent, do you want to chime in on this? Looks like an obvious error to me, but maybe I'm missing something and we should teach Coverity to shut up about it. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/