Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758904Ab3FMST3 (ORCPT ); Thu, 13 Jun 2013 14:19:29 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:36343 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717Ab3FMST0 (ORCPT ); Thu, 13 Jun 2013 14:19:26 -0400 From: "Rafael J. Wysocki" To: Jiang Liu Cc: Bjorn Helgaas , Yinghai Lu , "Alexander E . Patrakov" , Greg Kroah-Hartman , Yijing Wang , Jiang Liu , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Shaohua Li , Len Brown , linux-acpi@vger.kernel.org Subject: Re: [BUGFIX 5/9] ACPI, DOCK: kill redundant spin lock in dock device object Date: Thu, 13 Jun 2013 20:28:40 +0200 Message-ID: <1490442.eFer0nddaj@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0-rc5+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <1371141152-9468-6-git-send-email-jiang.liu@huawei.com> References: <1371141152-9468-1-git-send-email-jiang.liu@huawei.com> <1371141152-9468-6-git-send-email-jiang.liu@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2488 Lines: 77 On Friday, June 14, 2013 12:32:28 AM Jiang Liu wrote: > All dock device related data structures are created during driver > initialization, so kill the redundant spin lock in dock device object. As a cleanup, it definitely makes sense, but does it fix anything? Rafael > Signed-off-by: Jiang Liu > Cc: Shaohua Li > Cc: Len Brown > Cc: "Rafael J. Wysocki" > Cc: linux-acpi@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/acpi/dock.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c > index 8e578aa..cd2d5df 100644 > --- a/drivers/acpi/dock.c > +++ b/drivers/acpi/dock.c > @@ -57,7 +57,6 @@ struct dock_station { > acpi_handle handle; > unsigned long last_dock_time; > u32 flags; > - spinlock_t dd_lock; > struct mutex hp_lock; > struct task_struct *owner; > struct list_head dependent_devices; > @@ -107,10 +106,7 @@ add_dock_dependent_device(struct dock_station *ds, acpi_handle handle) > dd->handle = handle; > INIT_LIST_HEAD(&dd->list); > INIT_LIST_HEAD(&dd->hotplug_list); > - > - spin_lock(&ds->dd_lock); > list_add_tail(&dd->list, &ds->dependent_devices); > - spin_unlock(&ds->dd_lock); > > return 0; > } > @@ -168,14 +164,10 @@ find_dock_dependent_device(struct dock_station *ds, acpi_handle handle) > { > struct dock_dependent_device *dd; > > - spin_lock(&ds->dd_lock); > - list_for_each_entry(dd, &ds->dependent_devices, list) { > - if (handle == dd->handle) { > - spin_unlock(&ds->dd_lock); > + list_for_each_entry(dd, &ds->dependent_devices, list) > + if (handle == dd->handle) > return dd; > - } > - } > - spin_unlock(&ds->dd_lock); > + > return NULL; > } > > @@ -964,7 +956,6 @@ static int __init dock_add(acpi_handle handle) > dock_station->last_dock_time = jiffies - HZ; > > mutex_init(&dock_station->hp_lock); > - spin_lock_init(&dock_station->dd_lock); > INIT_LIST_HEAD(&dock_station->sibling); > INIT_LIST_HEAD(&dock_station->hotplug_devices); > INIT_LIST_HEAD(&dock_station->dependent_devices); > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/