Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758929Ab3FMSUJ (ORCPT ); Thu, 13 Jun 2013 14:20:09 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:61321 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754414Ab3FMSUH (ORCPT ); Thu, 13 Jun 2013 14:20:07 -0400 MIME-Version: 1.0 In-Reply-To: <1371141522-29255-3-git-send-email-dianders@chromium.org> References: <1371058399-31933-1-git-send-email-dianders@chromium.org> <1371141522-29255-3-git-send-email-dianders@chromium.org> Date: Thu, 13 Jun 2013 20:20:06 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking From: Linus Walleij To: Doug Anderson Cc: Kukjin Kim , Tomasz Figa , Olof Johansson , Simon Glass , Luigi Semenzato , ilho215.lee@samsung.com, Eunki Kim , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 24 On Thu, Jun 13, 2013 at 6:38 PM, Doug Anderson wrote: > A level-triggered interrupt should be acked after the interrupt line > becomes inactive and before it is unmasked, or else another interrupt > will be immediately triggered. Acking before or after calling the > handler is not enough. > > Signed-off-by: Luigi Semenzato > Signed-off-by: Doug Anderson > --- > Changes in v2: > - Greatly simplified using Tomasz's suggestion of irqd_get_trigger_type > - Moved acking out of the bank spinlock since since it's not needed. > - Linus W. has already applied parts 1 and 2, so not resending. Thanks, this v2 version applied with Tomasz ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/