Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759064Ab3FMS0M (ORCPT ); Thu, 13 Jun 2013 14:26:12 -0400 Received: from mail-qe0-f52.google.com ([209.85.128.52]:62484 "EHLO mail-qe0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759056Ab3FMS0J (ORCPT ); Thu, 13 Jun 2013 14:26:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <1371141152-9468-1-git-send-email-jiang.liu@huawei.com> Date: Fri, 14 Jun 2013 00:26:07 +0600 Message-ID: Subject: Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver From: "Alexander E. Patrakov" To: Jiang Liu Cc: "Rafael J . Wysocki" , Bjorn Helgaas , Yinghai Lu , Greg Kroah-Hartman , Yijing Wang , Jiang Liu , linux-pci@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1767 Lines: 41 2013/6/13 Alexander E. Patrakov : > 2013/6/13 Jiang Liu : >> Alexander E. Patrakov reports two bugs related to >> dock station support on Sony VAIO VPCZ23A4R. Actually there are at least >> four bugs related to Sony VAIO VPCZ23A4R dock support. >> 1) can't correctly detect hotplug slot for dock state >> 2) resource leak on undocking >> 3) resource allocation failure for dock devices >> 4) one bug in intel_snd_hda driver >> >> The first patch fixes issue 1, and the second patch fixes issue 2. >> These two patches, if accepted, should be material for stable branches >> too. >> Patch 3-9 are code improvement for ACPI and dock driver. >> >> I have found the root cause for issue three, but still working on >> solutions, and seems can't be solve in short time. So please help >> to review and test patches for issue 1) and 2) first. >> >> Hi Alexander, could you please help to test the whole patchset? > > Tested on top of 3.10-rc5, with no other patches applied. > Unfortunately, lockdep complains on the second docking attempt in the > initially-undocked case. Please see the attached dmesg output. > > I have not tested the initially-docked case yet, will do that in 10 minutes. Tested. The device list is updated as expected if the radeon driver is blacklisted and there are no open fds to the audio card. If radeon is not blacklisted, I hit https://bugzilla.kernel.org/show_bug.cgi?id=59681 , but it is not a regression. -- Alexander E. Patrakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/