Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758705Ab3FMXJt (ORCPT ); Thu, 13 Jun 2013 19:09:49 -0400 Received: from mail-ea0-f179.google.com ([209.85.215.179]:51480 "EHLO mail-ea0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756038Ab3FMXJr (ORCPT ); Thu, 13 Jun 2013 19:09:47 -0400 From: Tomasz Figa To: Kukjin Kim Cc: "'Doug Anderson'" , "'Stephen Rothwell'" , "'linux-samsung-soc'" , "'Linus Walleij'" , "'Olof Johansson'" , "'Mauro Carvalho Chehab'" , "'Andrew Morton'" , "'Cesar Eduardo Barros'" , "'David S. Miller'" , "'Hans Verkuil'" , linux-kernel@vger.kernel.org, "'Thomas Abraham'" , arnd@linaro.org Subject: Re: [PATCH] MAINTAINERS: Add Samsung pinctrl entries Date: Fri, 14 Jun 2013 01:09:45 +0200 Message-ID: <1631975.J8WIPG7Wr5@flatron> User-Agent: KMail/4.10.4 (Linux/3.9.5-gentoo; KDE/4.10.4; x86_64; ; ) In-Reply-To: <8636798.mrxGehVc2F@flatron> References: <1371143144-31764-1-git-send-email-dianders@chromium.org> <15cf01ce6884$8c073f20$a415bd60$%kim@samsung.com> <8636798.mrxGehVc2F@flatron> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5308 Lines: 147 On Friday 14 of June 2013 00:49:08 Tomasz Figa wrote: > On Friday 14 of June 2013 07:22:53 Kukjin Kim wrote: > > Tomasz Figa wrote: > > > On Thursday 13 of June 2013 10:25:02 Doug Anderson wrote: > > > > Tomasz, > > > > > > > > On Thu, Jun 13, 2013 at 10:13 AM, Tomasz Figa > > > > > > > > > > wrote: > > > > > On Thursday 13 of June 2013 10:05:44 Doug Anderson wrote: > > > > >> It's convenient if get_maintainer suggests sending > > > > >> samsung/exynos > > > > >> pinctrl changes to linux-samsung-soc and to Kukjin. Add an > > > > >> entry > > > > >> for > > > > >> that. > > > > > > > > > > Well, if we are already at it, we could list the actual > > > > > maintainers of > > > > > the driver. > > > > > > > > > > The original maintainer was Thomas Abraham > > > > > > > > > > (added to CC) and after joining to development of this driver > > > > > last > > > > > year I have become a de facto maintainer as well, so... > > > > > > > > > >> Signed-off-by: Doug Anderson > > > > >> --- > > > > >> > > > > >> MAINTAINERS | 10 ++++++++++ > > > > >> 1 file changed, 10 insertions(+) > > > > >> > > > > >> diff --git a/MAINTAINERS b/MAINTAINERS > > > > >> index 8d97b3e..d026e38 100644 > > > > >> --- a/MAINTAINERS > > > > >> +++ b/MAINTAINERS > > > > >> @@ -6284,6 +6284,16 @@ L: > > > > >> linux-arm-kernel@lists.infradead.org > > > > >> (moderated for non-subscribers) S: Maintained > > > > >> > > > > >> F: drivers/pinctrl/pinctrl-at91.c > > > > >> > > > > >> +PIN CONTROLLER - SAMSUNG > > > > >> +M: Linus Walleij > > > > >> +M: Kukjin Kim > > > > > > > > > > So actually this would be: > > > > > M: Thomas Abraham > > > > > M: Tomasz Figa > > > > > > > > > > Thomas, do you agree on this? > > > > > > > > Ah. Wasn't sure where the official maintainership should lie. ;) > > > > If > > > > Thomas is happy with this then I'll spin and re-send. Shall I > > > > remove > > > > Kukjin and Linus, then? It's convenient to have Linus on the list > > > > since he tends to be the one applying the patches... > > > > > > From my understanding how it works, there is no need to list Linus > > > in > > > particular drivers, because he's already listed as a maintainer of > > > the > > > whole pinctrl subsystem and get-maintainer accounts for this. > > > > > > Similarly for Kukjin, he's listed as the main Samsung maintainer > > > already, > > > > If so, the directory like pinctrl should be added under Samsung ARM > > Architectures like spi and sound for Samsung stuff... > > One more thing. > > As Joe Perches suggested, we might as well add > > N: exynos > > to ARM/S5P EXYNOS ARM ARCHITECTURE entry, but I'm not really sure if > it's the right thing to do. To clarify things a bit, I'm not against doing it. Just I don't think I'm the one to decide about it. Best regards, Tomasz > > > but AFAIK in this case the script can't infer this based on > > > directory > > > > > structure. Let's see how it's done for other Samsung drivers: > > Well, I don't think so, because pinctrl has the close relationship > > with > > exynos arch part and it's little bit different with following. Just in > > my understanding. > > > > > DRM DRIVERS FOR EXYNOS > > > M: Inki Dae > > > M: Joonyoung Shim > > > M: Seung-Woo Kim > > > M: Kyungmin Park > > > L: dri-devel@lists.freedesktop.org > > > T: git > > > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm- > > > exynos.git > > > S: Supported > > > F: drivers/gpu/drm/exynos > > > F: include/drm/exynos* > > > F: include/uapi/drm/exynos* > > > > > > EXYNOS DP DRIVER > > > M: Jingoo Han > > > L: linux-fbdev@vger.kernel.org > > > S: Maintained > > > F: drivers/video/exynos/exynos_dp* > > > F: include/video/exynos_dp* > > > > > > EXYNOS MIPI DISPLAY DRIVERS > > > M: Inki Dae > > > M: Donghwa Lee > > > M: Kyungmin Park > > > L: linux-fbdev@vger.kernel.org > > > S: Maintained > > > F: drivers/video/exynos/exynos_mipi* > > > F: include/video/exynos_mipi* > > > > > > ARM/SAMSUNG S5P SERIES 2D GRAPHICS ACCELERATION (G2D) SUPPORT > > > M: Kyungmin Park > > > M: Kamil Debski > > > L: linux-arm-kernel@lists.infradead.org > > > L: linux-media@vger.kernel.org > > > S: Maintained > > > F: drivers/media/platform/s5p-g2d/ > > > > And I'm asking above all guys _really_ do review and maintaining the > > file or directories? I don't think so. > > > > > and so on. > > > > > > So I think, based on this precedent, we can do the same for pinctrl. > > > Let's wait to see Thomas' view on this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/