Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759563Ab3FNCaS (ORCPT ); Thu, 13 Jun 2013 22:30:18 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:33752 "EHLO mail-oa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755084Ab3FNCaQ (ORCPT ); Thu, 13 Jun 2013 22:30:16 -0400 MIME-Version: 1.0 In-Reply-To: <51BA7B3D.1020402@huawei.com> References: <1371141152-9468-1-git-send-email-jiang.liu@huawei.com> <51BA7B3D.1020402@huawei.com> Date: Thu, 13 Jun 2013 19:30:14 -0700 X-Google-Sender-Auth: rq2aLVhrRdiA16K19bSJ8_Vb0pE Message-ID: Subject: Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver From: Yinghai Lu To: "Jiang Liu (Gerry)" Cc: "Rafael J . Wysocki" , Bjorn Helgaas , "Alexander E . Patrakov" , Greg Kroah-Hartman , Yijing Wang , Jiang Liu , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2885 Lines: 64 On Thu, Jun 13, 2013 at 7:09 PM, Jiang Liu (Gerry) wrote: > On 2013/6/14 2:42, Yinghai Lu wrote: >> >> On Thu, Jun 13, 2013 at 9:32 AM, Jiang Liu wrote: >>> >>> Alexander E. Patrakov reports two bugs related to >>> dock station support on Sony VAIO VPCZ23A4R. Actually there are at least >>> four bugs related to Sony VAIO VPCZ23A4R dock support. >>> 1) can't correctly detect hotplug slot for dock state >>> 2) resource leak on undocking >>> 3) resource allocation failure for dock devices >>> 4) one bug in intel_snd_hda driver >>> >>> The first patch fixes issue 1, and the second patch fixes issue 2. >>> These two patches, if accepted, should be material for stable branches >>> too. >>> Patch 3-9 are code improvement for ACPI and dock driver. >>> >>> I have found the root cause for issue three, but still working on >>> solutions, and seems can't be solve in short time. So please help >>> to review and test patches for issue 1) and 2) first. >> >> >> the 3) is about pci resource allocation? >> because pcibios_add_bus is called too early? >> >> If that is case, we should have something like attached patch for it. >> >> With that, we will not need to worry about _OSC set for 3.10 etc. >> > Hi Yinghai, > Seems not related to pcibios_add_bus(). According to my > investigation, the issue is caused by difference in PCI resource > assignment between boot time and runtime hotplug. On x86 platforms, > it respects PCI resource assignment from BIOS and only reassign > resources for unassigned BARs. But with acpiphp, it ignores BIOS > resource assignment and reassign all resources by OS. > If we have enough resources, reassigning all PCI resources should > work too, but may fail if we are under resource constraints. On the > other handle, current PCI IOMM align algorithm may waste huge MMIO > address space if we have some PCI devices with huge IOMM BAR. > On this Sony laptop, BIOS allocates limited IOMM resources for > the dock station and the dock station has a gfx which has a 256MB > IOMM BAR. So current acpiphp driver fails to allocate resources > for most devices on the dock station. Is it a regression? > Currently I'm trying to change acpiphp to respect BIOS resource > assignment by calling pcibios_survey_resource_bus(), as in pci_root.c. > The other way is to change the IOMM resource allocation algorithm, > but obviously it's much more risky of regressions if changing the > algorithm. that is not going to help, need to increase bridge resource. please check if BIOS have setup option about hotplug MMIO pad size. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/