Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751220Ab3FNDnw (ORCPT ); Thu, 13 Jun 2013 23:43:52 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:54940 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051Ab3FNDnv (ORCPT ); Thu, 13 Jun 2013 23:43:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <1371141152-9468-1-git-send-email-jiang.liu@huawei.com> <51BA7B3D.1020402@huawei.com> <51BA8524.9050507@huawei.com> Date: Thu, 13 Jun 2013 20:43:50 -0700 X-Google-Sender-Auth: -mb51aKnTkkSbrzUi3TaWOkyVW8 Message-ID: Subject: Re: [BUGFIX 0/9] Fix bug 59501 and code improvement for dock driver From: Yinghai Lu To: "Jiang Liu (Gerry)" Cc: "Rafael J . Wysocki" , Bjorn Helgaas , "Alexander E . Patrakov" , Greg Kroah-Hartman , Yijing Wang , Jiang Liu , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1582 Lines: 37 On Thu, Jun 13, 2013 at 8:30 PM, Yinghai Lu wrote: > On Thu, Jun 13, 2013 at 7:51 PM, Jiang Liu (Gerry) wrote: >> For the first step, I'm trying to make hotplug case work in the same way as >> boot time. Do you think this patch help? >> >> diff --git a/drivers/pci/hotplug/acpiphp_glue.c >> b/drivers/pci/hotplug/acpiphp_gl >> index 270fdba..12e3f6e 100644 >> --- a/drivers/pci/hotplug/acpiphp_glue.c >> +++ b/drivers/pci/hotplug/acpiphp_glue.c >> @@ -837,13 +837,13 @@ static int __ref enable_device(struct acpiphp_slot >> *slot) >> max = pci_scan_bridge(bus, dev, max, pass); >> if (pass && dev->subordinate) { >> check_hotplug_bridge(slot, dev); >> - pci_bus_size_bridges(dev->subordinate); >> + pcibios_resource_survey_bus(dev->subordi >> } >> } >> } >> } >> >> - pci_bus_assign_resources(bus); >> + pci_assign_unassigned_bus_resources(bus); can not use use pci_assign_unassigned_bus_resources directly. as bus could have devices that is there already before this enable_device and could have driver loaded before. that is why we have checking if (PCI_SLOT(dev->devfn) != slot->device) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/