Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753449Ab3FNQ5c (ORCPT ); Fri, 14 Jun 2013 12:57:32 -0400 Received: from mail-oa0-f41.google.com ([209.85.219.41]:34655 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795Ab3FNQ5b (ORCPT ); Fri, 14 Jun 2013 12:57:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130401235256.GA31966@google.com> <20130614141101.GA29452@google.com> Date: Fri, 14 Jun 2013 09:57:30 -0700 X-Google-Sender-Auth: eGHBvGFH7nEbQf8GovuKDxuJue0 Message-ID: Subject: Re: [PATCH] PCI: Remove not needed check in disable aspm link From: Yinghai Lu To: Bjorn Helgaas Cc: Jiang Liu , Roman Yepishev , "Rafael J. Wysocki" , "linux-pci@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Torvalds , Andrew Morton , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 27 On Fri, Jun 14, 2013 at 9:33 AM, Bjorn Helgaas wrote: > On Fri, Jun 14, 2013 at 10:17 AM, Yinghai Lu wrote: > > Can you please refer to specific function names? I can't read your mind. > > You might be referring to quirk_disable_aspm_l0s(). This is a > pci_fixup_final quirk that calls pci_disable_link_state(). In the > current tree, we enumerate devices before requesting _OSC control. > However, pci_fixup_final quirks are not run until the > pci_apply_final_quirks() fs_initcall, which is after we request _OSC > control. > > As far as I can tell, we never call pci_disable_link_state() before > calling pcie_no_aspm(). ok, you are right, that is not pci_disable_link_state. It is pcie_aspm_init_link_state ==> pcie_aspm_sanity_check in booting path that disable aspm. It has "if (aspm_disabled)" in it, and it cause the difference. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/