Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752636Ab3FNR5S (ORCPT ); Fri, 14 Jun 2013 13:57:18 -0400 Received: from mail-gh0-f169.google.com ([209.85.160.169]:46422 "EHLO mail-gh0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512Ab3FNR5R (ORCPT ); Fri, 14 Jun 2013 13:57:17 -0400 Date: Fri, 14 Jun 2013 10:57:10 -0700 From: Tejun Heo To: Wanpeng Li Cc: Andrew Morton , Michal Hocko , David Rientjes , "Kirill A. Shutemov" , Fengguang Wu , Rik van Riel , Andrew Shewmaker , Jiri Kosina , Namjae Jeon , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] mm/writeback: rename WB_REASON_FORKER_THREAD to WB_REASON_WORKER_THREAD Message-ID: <20130614175710.GB6593@mtj.dyndns.org> References: <1371195041-26654-1-git-send-email-liwanp@linux.vnet.ibm.com> <1371195041-26654-4-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1371195041-26654-4-git-send-email-liwanp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 879 Lines: 21 On Fri, Jun 14, 2013 at 03:30:37PM +0800, Wanpeng Li wrote: > After commit 839a8e86("writeback: replace custom worker pool implementation > with unbound workqueue"), there is no bdi forker thread any more. This patch > rename WB_REASON_FORKER_THREAD to WB_REASON_WORKER_THREAD since works are > done by emergency worker. This is somewhat userland visible and we'll be exposing exactly the same information with just a different name. While the string doesn't match the current implementation exactly, I don't think we need to change it. Maybe add a comment there saying why it has a mismatching name is enough? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/