Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893Ab3FNSAG (ORCPT ); Fri, 14 Jun 2013 14:00:06 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:44197 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751985Ab3FNSAD (ORCPT ); Fri, 14 Jun 2013 14:00:03 -0400 Date: Fri, 14 Jun 2013 11:00:01 -0700 From: Stephen Boyd To: Rob Herring Cc: Russell King , linux-arm-msm , Rob Herring , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Stephen Warren Subject: Re: [PATCH] ARM: mmu: Add debug_ll_io_init() mappings to early mappings Message-ID: <20130614180001.GB3399@codeaurora.org> References: <1371000607-1787-1-git-send-email-sboyd@codeaurora.org> <20130612172146.GB10823@codeaurora.org> <51BB15DA.8020302@gmail.com> <20130614164524.GA3399@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130614164524.GA3399@codeaurora.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1420 Lines: 35 On 06/14, Stephen Boyd wrote: > On 06/14, Rob Herring wrote: > > On 06/12/2013 12:21 PM, Stephen Boyd wrote: > > > On 06/11, Rob Herring wrote: > > >> Can you use vm_reserve_area_early here or perhaps just call > > >> iotable_init instead of create_mapping directly? I don't recall if > > >> there was some reason I didn't do that. > > >> > > > > > > I had iotable_init() before but I thought it was better to have > > > the ->caller argument say debug_ll_io_init() instead of > > > iotable_init(). Shall I extract out the similar code? > > > > Well, that's always welcome... > > > > Another option would be use __builtin_return_address. That would change > > vmallocinfo from showing iotable_init to the caller of iotable_init. > > Arguably, knowing the caller would be better. > > > > Ok sounds fair. I'll use iotable_init() and send a follow-up > patch to make iotable_init() more informative. > Well now I get paging_init() as the function because that's where we're going to return to. That actually seems less informative. I'll do the similar code extraction. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/