Date: Fri, 14 Jun 2013 14:54:02 -0400
From: Vivek Goyal <vgoyal@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
        Jan Willeke <willeke@de.ibm.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        linux-kernel@vger.kernel.org, kexec@lists.infradead.org
Subject: Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature
Message-ID: <20130614185401.GL12023@redhat.com>
References: <1370624161-2298-1-git-send-email-holzheu@linux.vnet.ibm.com>
 <1370624161-2298-2-git-send-email-holzheu@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1370624161-2298-2-git-send-email-holzheu@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1206
Lines: 45

On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote:

[..]
> @@ -935,10 +967,17 @@ static int __init vmcore_init(void)
>  {
>  	int rc = 0;
>  
> -	/* If elfcorehdr= has been passed in cmdline, then capture the dump.*/
> -	if (!(is_vmcore_usable()))
> -		return rc;
> +	/*
> +	 * If elfcorehdr= has not been passed in cmdline, try to get the
> +	 * header from 2nd kernel, then capture the dump.
> +	 */
> +	if (!(is_vmcore_usable())) {
> +		rc = elfcorehdr_alloc();
> +		if (rc)
> +			return rc;
> +	}

Hi Michael,

Patch description says that elfcorehdr_alloc() returns the addr and 
size of elf headers. But that does not seem to be the case here. Has
it been modified in later patches.

Also will it be better if we call elfcorehdr_alloc() always and then
check for is_vmcore_usable().

Something like.

elfcorehdr_addr = elfcorehdr_alloc()
if (elfcorehdr_addr < )
	return elfcorehdr_addr

if (!(is_vmcore_usable()))
	return error

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/