Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753843Ab3FNSzq (ORCPT ); Fri, 14 Jun 2013 14:55:46 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:34596 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973Ab3FNSzn (ORCPT ); Fri, 14 Jun 2013 14:55:43 -0400 Message-ID: <1371236142.2726.43.camel@dabdike> Subject: [PATCH RESEND] fix WARNING: at kernel/cpu/idle.c:96 From: James Bottomley To: Parisc List Cc: Thomas Gleixner , linux-kernel , Andrew Morton Date: Fri, 14 Jun 2013 11:55:42 -0700 Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.8.2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1487 Lines: 42 >From 48bbf44a96676ce6f520a408378730c976e9a11e Mon Sep 17 00:00:00 2001 From: James Bottomley Date: Wed, 8 May 2013 14:05:34 -0700 Subject: [PATCH] [PARISC] fix WARNING: at kernel/cpu/idle.c:96 On PA-RISC (and presumably any other arch that doesn't implement its own arch_cpu_idle), we get this spurious boot warning. The problem is that the way the idle task is selected initially using the weak arch_cpu_idle() in idle.c causes us to enter this place once with interrupts enabled. Fix this by disabling interrupts in the weak arch_cpu_idle() code. Reviewed-by: Srivatsa S. Bhat Cc: stable@vger.kernel.org Signed-off-by: James Bottomley --- Thomas, I'm getting a bit impatient: this is a clear bug in the cpu idle code and we keep getting reports of this as a boot crash on parisc. If you don't push it through your tree, I'll take it through the parisc one. diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c index d5585f5..0a4d11e 100644 --- a/kernel/cpu/idle.c +++ b/kernel/cpu/idle.c @@ -58,6 +58,7 @@ void __weak arch_cpu_idle_dead(void) { } void __weak arch_cpu_idle(void) { cpu_idle_force_poll = 1; + local_irq_enable(); } /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/