Message-ID: <1371237192.2726.46.camel@dabdike>
Subject: Re: [PATCH RESEND] fix WARNING: at kernel/cpu/idle.c:96
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Parisc List <linux-parisc@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Date: Fri, 14 Jun 2013 12:13:12 -0700
In-Reply-To: <51BB6AE3.8030903@gmail.com>
References: <1371236142.2726.43.camel@dabdike> <51BB6AE3.8030903@gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1171
Lines: 27

On Fri, 2013-06-14 at 12:11 -0700, David Daney wrote:
> On 06/14/2013 11:55 AM, James Bottomley wrote:
> >>From 48bbf44a96676ce6f520a408378730c976e9a11e Mon Sep 17 00:00:00 2001
> > From: James Bottomley <JBottomley@Parallels.com>
> > Date: Wed, 8 May 2013 14:05:34 -0700
> > Subject: [PATCH] [PARISC] fix WARNING: at kernel/cpu/idle.c:96
> >
> > On PA-RISC (and presumably any other arch that doesn't implement its own
> > arch_cpu_idle), we get this spurious boot warning.  The problem is that the
> > way the idle task is selected initially using the weak arch_cpu_idle() in
> > idle.c causes us to enter this place once with interrupts enabled.  Fix this
> > by disabling interrupts in the weak arch_cpu_idle() code.
> 
> Is this changelog correct?  It looks to me like you are enabling 
> interrupts down there.

Yes, obvious typo, sorry.  The WARN_ON check is for disabled interrupts
the fix is to enable them.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/