Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753906Ab3FOCRi (ORCPT ); Fri, 14 Jun 2013 22:17:38 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:6273 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512Ab3FOCRh (ORCPT ); Fri, 14 Jun 2013 22:17:37 -0400 X-Authority-Analysis: v=2.0 cv=Du3UCRD+ c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=w1cNLofYa50A:10 a=5SG0PmZfjMsA:10 a=IkcTkHD0fZMA:10 a=meVymXHHAAAA:8 a=KGjhK52YXX0A:10 a=yqaEuN8awxIA:10 a=DLAt90JVuYke8LvinfEA:9 a=QEXdDO2ut3YA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 74.67.115.198 Message-ID: <1371262654.9844.340.camel@gandalf.local.home> Subject: Re: Regression in RCU subsystem in latest mainline kernel From: Steven Rostedt To: Benjamin Herrenschmidt Cc: Rojhalat Ibrahim , paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev Date: Fri, 14 Jun 2013 22:17:34 -0400 In-Reply-To: <1371261741.21896.20.camel@pasglop> References: <1626500.7WAVXjfS9F@pcimr> <20130614122800.GL5146@linux.vnet.ibm.com> <1645938.As0LR1yeVd@pcimr> <1371243967.9844.338.camel@gandalf.local.home> <1371261741.21896.20.camel@pasglop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 38 On Sat, 2013-06-15 at 12:02 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2013-06-14 at 17:06 -0400, Steven Rostedt wrote: > > I was pretty much able to reproduce this on my PA Semi PPC box. Funny > > thing is, when I type on the console, it makes progress. Anyway, it > > seems that powerpc has an issue with irq_work(). I'll try to get some > > time either tonight or next week to figure it out. > > Does this help ? It did for me. Rojhalat, did this fix your issue too? -- Steve > > diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c > index 5cbcf4d..ea185e0 100644 > --- a/arch/powerpc/kernel/irq.c > +++ b/arch/powerpc/kernel/irq.c > @@ -162,7 +162,7 @@ notrace unsigned int __check_irq_replay(void) > * in case we also had a rollover while hard disabled > */ > local_paca->irq_happened &= ~PACA_IRQ_DEC; > - if (decrementer_check_overflow()) > + if ((happened & PACA_IRQ_DEC) || decrementer_check_overflow()) > return 0x900; > > /* Finally check if an external interrupt happened */ > > Cheers, > Ben. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/