Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754366Ab3FONRl (ORCPT ); Sat, 15 Jun 2013 09:17:41 -0400 Received: from mailout02.c08.mtsvc.net ([205.186.168.190]:42752 "EHLO mailout02.c08.mtsvc.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754191Ab3FONO5 (ORCPT ); Sat, 15 Jun 2013 09:14:57 -0400 From: Peter Hurley To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , Peter Hurley Subject: [PATCH v4 01/24] tty: Don't change receive_room for ioctl(TIOCSETD) Date: Sat, 15 Jun 2013 09:14:13 -0400 Message-Id: <1371302076-4688-2-git-send-email-peter@hurleysoftware.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1371302076-4688-1-git-send-email-peter@hurleysoftware.com> References: <1366039168-8510-1-git-send-email-peter@hurleysoftware.com> <1371302076-4688-1-git-send-email-peter@hurleysoftware.com> X-Authenticated-User: 125194 peter@hurleysoftware.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 31 tty_set_ldisc() is guaranteed exclusive use of the line discipline by tty_ldisc_lock_pair_timeout(); shutting off input by resetting receive_room is unnecessary. Signed-off-by: Peter Hurley --- drivers/tty/tty_ldisc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index edeb1dd..86356e3 100644 --- a/drivers/tty/tty_ldisc.c +++ b/drivers/tty/tty_ldisc.c @@ -540,9 +540,6 @@ int tty_set_ldisc(struct tty_struct *tty, int ldisc) return 0; } - /* FIXME: why 'shutoff' input if the ldisc is locked? */ - tty->receive_room = 0; - old_ldisc = tty->ldisc; tty_lock(tty); -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/