Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754814Ab3FOXve (ORCPT ); Sat, 15 Jun 2013 19:51:34 -0400 Received: from mail-ob0-f175.google.com ([209.85.214.175]:64847 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754639Ab3FOXvd convert rfc822-to-8bit (ORCPT ); Sat, 15 Jun 2013 19:51:33 -0400 MIME-Version: 1.0 In-Reply-To: <1795038.rqcr6GWLdP@avalon> References: <1370988237-30593-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <201306152216.14252.heiko@sntech.de> <1795038.rqcr6GWLdP@avalon> Date: Sun, 16 Jun 2013 01:51:32 +0200 Message-ID: Subject: Re: [RFC] pinctrl: generic: Add DT bindings From: Linus Walleij To: Laurent Pinchart Cc: =?ISO-8859-1?Q?Heiko_St=FCbner?= , "linux-kernel@vger.kernel.org" , Grant Likely , "devicetree-discuss@lists.ozlabs.org" , James Hogan , "linux-sh@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 40 On Sun, Jun 16, 2013 at 1:35 AM, Laurent Pinchart wrote: > On Saturday 15 June 2013 22:16:13 Heiko St?bner wrote: >> Am Samstag, 15. Juni 2013, 21:56:05 schrieb Linus Walleij: >> Disable would the be either >> bias-disable; >> or >> bias-pull-up = <0>; >> >> A driver should probably handle both, as both are valid pinconf options or >> this. > > I feel a bit uneasy about that. Do we really need to support two different > ways to achieve the same result ? In this specific case I think yes, but not on all options. As dicussed earlier this was designed for systems where you could set the pull-up resistance, like bias-pull-up = <600000>; would give 600kOhm pull up. In most existing systems that is silly, as they can't specify it, so they should be able to do just: bias-pull-up; as that is all they can do. If we have to cut one way, we should cut the former until such a system appears. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/