Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755582Ab3FQAjr (ORCPT ); Sun, 16 Jun 2013 20:39:47 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:54307 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618Ab3FQAjq (ORCPT ); Sun, 16 Jun 2013 20:39:46 -0400 MIME-Version: 1.0 In-Reply-To: <20130616091005.GP18614@n2100.arm.linux.org.uk> References: <1371338108-26354-1-git-send-email-grant.likely@linaro.org> <20130616091005.GP18614@n2100.arm.linux.org.uk> From: Grant Likely Date: Mon, 17 Jun 2013 01:39:25 +0100 X-Google-Sender-Auth: 8feRIaNji7Z_Dn3XJGgFXPccvks Message-ID: Subject: Re: [RFC] arm: Remove sa1111 special case from mm setup code To: Russell King - ARM Linux Cc: Nicolas Pitre , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , Catalin Marinas Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 26 On Sun, Jun 16, 2013 at 10:10 AM, Russell King - ARM Linux wrote: > On Sun, Jun 16, 2013 at 12:15:08AM +0100, Grant Likely wrote: >> I don't think this special case is needed anymore. From what I can tell, >> setup_dma_zone() takes care of marking the region to be reserved for >> DMA, and that happens before arm_memblock_init() which calls >> arm_mm_memblock_reserve(). Therefore the mm setup should already know >> about the reserved region and it won't need to be explicitly reserved >> and then freed. That means the special case can be dropped from the >> common code. > > No it doesn't. setup_dma_zone is all about setting the high watermark > for GFP_DMA allocations. It has nothing to do with _temoprarily_ > reserving the low 1MB, ensuring that no other user can use any of that > precious SA1111 memory during the kernel boot. Ah, okay. So it's to protect against early allocations. All right, I've got an alternate patch that at least gets rid of one of the special case hooks. I'll post that one shortly. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/