Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755121Ab3FQCAw (ORCPT ); Sun, 16 Jun 2013 22:00:52 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:2987 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754633Ab3FQCAt (ORCPT ); Sun, 16 Jun 2013 22:00:49 -0400 Message-ID: <51BE6D47.9020805@huawei.com> Date: Mon, 17 Jun 2013 09:58:31 +0800 From: Jianguo Wu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Tang Chen CC: , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [Part3 PATCH v2 0/4] Support hot-remove local pagetable pages. References: <1371128636-9027-1-git-send-email-tangchen@cn.fujitsu.com> In-Reply-To: <1371128636-9027-1-git-send-email-tangchen@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.74.216] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2929 Lines: 73 Hi Tang, On 2013/6/13 21:03, Tang Chen wrote: > The following patch-set from Yinghai allocates pagetables to local nodes. > v1: https://lkml.org/lkml/2013/3/7/642 > v2: https://lkml.org/lkml/2013/3/10/47 > v3: https://lkml.org/lkml/2013/4/4/639 > v4: https://lkml.org/lkml/2013/4/11/829 > > Since pagetable pages are used by the kernel, they cannot be offlined. > As a result, they cannot be hot-remove. > > This patch fix this problem with the following solution: > > 1. Introduce a new bootmem type LOCAL_NODE_DATAL, and register local > pagetable pages as LOCAL_NODE_DATAL by setting page->lru.next to > LOCAL_NODE_DATAL, just like we register SECTION_INFO pages. > > 2. Skip LOCAL_NODE_DATAL pages in offline/online procedures. When the > whole memory block they reside in is offlined, the kernel can > still access the pagetables. > (This changes the semantics of offline/online a little bit.) > > 3. Do not free LOCAL_NODE_DATAL pages to buddy system because they > were skipped when in offline/online procedures. The memory block > they reside in could have been offlined. > s/LOCAL_NODE_DATAL/LOCAL_NODE_DATA > Anyway, this problem should be fixed. Any better idea is welcome. > > Change log: > v1 -> v2: > patch2: As suggested by Wu Jianguo, define a macro to check if a page > cantains local node data. > patch4: As suggested by Wu Jianguo, prevent freeing LOCAL_NODE_DATA > pages in free_pagetable() instead of in put_page_bootmem(). > > Tang Chen (4): > bootmem, mem-hotplug: Register local pagetable pages with > LOCAL_NODE_DATA when freeing bootmem. > mem-hotplug: Skip LOCAL_NODE_DATA pages in memory offline procedure. > mem-hotplug: Skip LOCAL_NODE_DATA pages in memory online procedure. > mem-hotplug: Do not free LOCAL_NODE_DATA pages to buddy system in > hot-remove procedure. > > arch/x86/mm/init_64.c | 10 +++++++- > include/linux/memblock.h | 22 +++++++++++++++++ > include/linux/memory_hotplug.h | 20 +++++++++++++-- > mm/memblock.c | 52 ++++++++++++++++++++++++++++++++++++++++ > mm/memory_hotplug.c | 31 +++++++++++++++++++++++ > mm/page_alloc.c | 15 ++++++++++- > mm/page_isolation.c | 5 ++++ > 7 files changed, 149 insertions(+), 6 deletions(-) > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/