Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755883Ab3FQFuX (ORCPT ); Mon, 17 Jun 2013 01:50:23 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:60193 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800Ab3FQFuW (ORCPT ); Mon, 17 Jun 2013 01:50:22 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 17 Jun 2013 07:50:21 +0200 Message-ID: Subject: Re: [PATCH v2 6/6] DT: Add documentation for gpio-xilinx From: Linus Walleij To: Michal Simek Cc: "linux-kernel@vger.kernel.org" , Michal Simek , Arnd Bergmann , Grant Likely , Rob Herring , Rob Landley , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1668 Lines: 53 On Mon, Jun 3, 2013 at 2:31 PM, Michal Simek wrote: > Describe gpio-xilinx binding. > > Signed-off-by: Michal Simek > --- > Changes in v2: > - Extend description Thanks, patch applied but look into this: > +Optional properties: > +- interrupts : Interrupt mapping for GPIO IRQ. > +- interrupt-parent : Phandle for the interrupt controller that > + services interrupts for this device. > +- xlnx,all-inputs : if n-th bit is setup, GPIO-n is input > +- xlnx,dout-default : if n-th bit is 1, GPIO-n default value is 1 > +- xlnx,gpio-width : gpio width > +- xlnx,tri-default : if n-th bit is 1, GPIO-n is in tristate mode > +- xlnx,is-dual : if 1, controller also uses the second channel If is present, xlnx,is-dual; > +Example: > +gpio: gpio@40000000 { > + #gpio-cells = <2>; > + compatible = "xlnx,xps-gpio-1.00.a"; > + gpio-controller ; > + interrupt-parent = <µblaze_0_intc>; > + interrupts = < 6 2 >; > + reg = < 0x40000000 0x10000 >; > + xlnx,all-inputs = <0x0>; > + xlnx,all-inputs-2 = <0x0>; > + xlnx,dout-default = <0x0>; > + xlnx,dout-default-2 = <0x0>; > + xlnx,gpio-width = <0x2>; > + xlnx,gpio2-width = <0x2>; > + xlnx,interrupt-present = <0x1>; > + xlnx,is-dual = <0x1>; xlnx,is-dual; I'm not giving up on this suggestion. Test it please... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/