Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932319Ab3FQIKW (ORCPT ); Mon, 17 Jun 2013 04:10:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56657 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755089Ab3FQIKP (ORCPT ); Mon, 17 Jun 2013 04:10:15 -0400 Date: Mon, 17 Jun 2013 10:10:12 +0200 From: Michal Hocko To: Wanpeng Li Cc: Andrew Morton , David Rientjes , "Kirill A. Shutemov" , Fengguang Wu , Rik van Riel , Andrew Shewmaker , Jiri Kosina , Namjae Jeon , Jan Kara , Tejun Heo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/7] mm/page_alloc: fix blank in show_free_areas Message-ID: <20130617081012.GA19194@dhcp22.suse.cz> References: <1371345290-19588-1-git-send-email-liwanp@linux.vnet.ibm.com> <1371345290-19588-4-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1371345290-19588-4-git-send-email-liwanp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2593 Lines: 68 On Sun 16-06-13 09:14:47, Wanpeng Li wrote: > There is a blank in show_free_areas which lead to dump messages aren't > aligned. This patch remove blank. > > Before patch: > > [155219.720141] active_anon:50675 inactive_anon:35273 isolated_anon:0 > [155219.720141] active_file:215421 inactive_file:344268 isolated_file:0 > [155219.720141] unevictable:0 dirty:35 writeback:0 unstable:0 > [155219.720141] free:1334870 slab_reclaimable:28833 slab_unreclaimable:5115 > [155219.720141] mapped:25233 shmem:35511 pagetables:1705 bounce:0 > [155219.720141] free_cma:0 > > After patch: > > [ 73.913889] active_anon:39578 inactive_anon:32082 isolated_anon:0 > [ 73.913889] active_file:14621 inactive_file:57993 isolated_file:0 > [ 73.913889] unevictable:0dirty:263 writeback:0 unstable:0 > [ 73.913889] free:1865614 slab_reclaimable:3264 slab_unreclaimable:4566 > [ 73.913889] mapped:21192 shmem:32327 pagetables:1572 bounce:0 > [ 73.913889] free_cma:0 Not that I would care much but this format is here for ages. An additional space was kind of nice to visually separate this part from the per-zone data. Is there any special reason for this change? > Signed-off-by: Wanpeng Li > --- > mm/page_alloc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 18102e1..e6e881a 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3004,12 +3004,12 @@ void show_free_areas(unsigned int filter) > } > > printk("active_anon:%lu inactive_anon:%lu isolated_anon:%lu\n" > - " active_file:%lu inactive_file:%lu isolated_file:%lu\n" > - " unevictable:%lu" > - " dirty:%lu writeback:%lu unstable:%lu\n" > - " free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n" > - " mapped:%lu shmem:%lu pagetables:%lu bounce:%lu\n" > - " free_cma:%lu\n", > + "active_file:%lu inactive_file:%lu isolated_file:%lu\n" > + "unevictable:%lu" > + "dirty:%lu writeback:%lu unstable:%lu\n" There is a space missing between unevictable and dirty. > + "free:%lu slab_reclaimable:%lu slab_unreclaimable:%lu\n" > + "mapped:%lu shmem:%lu pagetables:%lu bounce:%lu\n" > + "free_cma:%lu\n", > global_page_state(NR_ACTIVE_ANON), > global_page_state(NR_INACTIVE_ANON), > global_page_state(NR_ISOLATED_ANON), -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/