Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932432Ab3FQIae (ORCPT ); Mon, 17 Jun 2013 04:30:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57761 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932314Ab3FQIad (ORCPT ); Mon, 17 Jun 2013 04:30:33 -0400 Date: Mon, 17 Jun 2013 10:30:30 +0200 From: Michal Hocko To: Wanpeng Li Cc: Andrew Morton , David Rientjes , "Kirill A. Shutemov" , Fengguang Wu , Rik van Riel , Andrew Shewmaker , Jiri Kosina , Namjae Jeon , Jan Kara , Tejun Heo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] mm/writeback: commit reason of WB_REASON_FORKER_THREAD mismatch name Message-ID: <20130617083030.GE19194@dhcp22.suse.cz> References: <1371345290-19588-1-git-send-email-liwanp@linux.vnet.ibm.com> <1371345290-19588-3-git-send-email-liwanp@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1371345290-19588-3-git-send-email-liwanp@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1456 Lines: 44 On Sun 16-06-13 09:14:46, Wanpeng Li wrote: > After commit 839a8e86("writeback: replace custom worker pool implementation > with unbound workqueue"), there is no bdi forker thread any more. However, > WB_REASON_FORKER_THREAD is still used due to it is somewhat userland visible What exactly "somewhat userland visible" means? Is this about trace events? > and we won't be exposing exactly the same information with just a different > name. > > Signed-off-by: Wanpeng Li > --- > include/linux/writeback.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > index 8b5cec4..cf077a7 100644 > --- a/include/linux/writeback.h > +++ b/include/linux/writeback.h > @@ -47,6 +47,11 @@ enum wb_reason { > WB_REASON_LAPTOP_TIMER, > WB_REASON_FREE_MORE_MEM, > WB_REASON_FS_FREE_SPACE, > +/* > + * There is no bdi forker thread any more and works are done by emergency > + * worker, however, this is somewhat userland visible and we'll be exposing > + * exactly the same information, so it has a mismatch name. > + */ > WB_REASON_FORKER_THREAD, > > WB_REASON_MAX, > -- > 1.8.1.2 > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/