Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932803Ab3FQLqD (ORCPT ); Mon, 17 Jun 2013 07:46:03 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:56522 "EHLO mail-oa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932741Ab3FQLqC convert rfc822-to-8bit (ORCPT ); Mon, 17 Jun 2013 07:46:02 -0400 MIME-Version: 1.0 In-Reply-To: References: <1371461892-5298-1-git-send-email-sachin.kamat@linaro.org> Date: Mon, 17 Jun 2013 17:16:01 +0530 Message-ID: Subject: Re: [PATCH Resend] pinctrl: exynos: Fix build breakage From: Sachin Kamat To: Linus Walleij Cc: "linux-kernel@vger.kernel.org" , linux-samsung-soc , Patch Tracking , Doug Anderson Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 38 On 17 June 2013 16:55, Linus Walleij wrote: > On Mon, Jun 17, 2013 at 11:38 AM, Sachin Kamat wrote: > >> 'exynos_wkup_irq_ack' should be defined ahead of its call. >> >> Fixes the following error: >> drivers/pinctrl/pinctrl-exynos.c: In function ?exynos_wkup_irq_mask?: >> drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declaration of >> function ?exynos_wkup_irq_ack? [-Werror=implicit-function-declaration] >> exynos_wkup_irq_ack(irqd); >> >> Signed-off-by: Sachin Kamat >> Cc: Doug Anderson >> --- >> Fixed the commit message. >> --- > > Applied. Thanks. > > Usually you should state which commit caused > the problem in the commit message. Usually I do. But in this case it was not caused by a single commit per se but a combination. Hence I wasn't sure if I should mention both as the ones causing it. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/