Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933014Ab3FQNKx (ORCPT ); Mon, 17 Jun 2013 09:10:53 -0400 Received: from mail-oa0-f53.google.com ([209.85.219.53]:44697 "EHLO mail-oa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932944Ab3FQNKv (ORCPT ); Mon, 17 Jun 2013 09:10:51 -0400 MIME-Version: 1.0 In-Reply-To: <20130617115809.5206c42c@amdc308.digital.local> References: <1370502472-7249-1-git-send-email-l.majewski@samsung.com> <1371195540-2991-1-git-send-email-l.majewski@samsung.com> <1371195540-2991-2-git-send-email-l.majewski@samsung.com> <20130617091549.398b865f@amdc308.digital.local> <20130617110811.1e1805d2@amdc308.digital.local> <20130617115809.5206c42c@amdc308.digital.local> Date: Mon, 17 Jun 2013 18:40:50 +0530 Message-ID: Subject: Re: [PATCH v3 1/3] cpufreq: Add boost frequency support in core From: Viresh Kumar To: Lukasz Majewski Cc: "Rafael J. Wysocky" , "cpufreq@vger.kernel.org" , Linux PM list , Vincent Guittot , Jonghwa Lee , Myungjoo Ham , linux-kernel , Lukasz Majewski , Andre Przywara , Daniel Lezcano , Kukjin Kim , Amit Daniel Kachhap Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 41 On 17 June 2013 15:28, Lukasz Majewski wrote: > Yes. But I don't want to hardcode anything. Especially starting CPU > number. There is nothing wrong with it. for_each_online_cpu() is good enough on these cases. >> > How one can control the boost? I'm now (on my setup) using thermal >> > subsystem. I set proper trip points and when one of them is met, >> > then boost is disabled. Moreover the thermal governor (stepwise) >> > also reduces frequency. >> > >> > It works stable with v3.10 (with 3.8 there were some bugs - now they >> > are fixed). >> > >> > >> > The core acpi-cpufreq.c code hadn't been changed by me, so I assume >> > that it will work as before. >> >> That should adapt your patch in your patchset. ?? >> From sysfs?? I thought we are going to have some automatic control >> of this stuff from inside kernel. > > From sysfs I just enable the boost. I do not order from userpace the > cpufreq to run with a particular (boosted) frequency. > > When I enable boost - I ask (politely) the cpufreq core to reevaluate > policies and when applicable increase policy->max. > > Then governor can use this new frequencies for normal operation. So, with your current patchset in, ondemand or conservative governors will start using boost frequencies. Which might burn your chip. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/