Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933031Ab3FQNVT (ORCPT ); Mon, 17 Jun 2013 09:21:19 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:44456 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755746Ab3FQNVS (ORCPT ); Mon, 17 Jun 2013 09:21:18 -0400 From: Rojhalat Ibrahim To: Steven Rostedt Cc: Benjamin Herrenschmidt , paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev Subject: Re: Regression in RCU subsystem in latest mainline kernel Date: Mon, 17 Jun 2013 15:21:15 +0200 Message-ID: <1558776.vQIgbXvFW8@pcimr> User-Agent: KMail/4.10.3 (Linux/3.4.26; KDE/4.10.3; x86_64; ; ) In-Reply-To: <1371262654.9844.340.camel@gandalf.local.home> References: <1626500.7WAVXjfS9F@pcimr> <1371261741.21896.20.camel@pasglop> <1371262654.9844.340.camel@gandalf.local.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 45 On Friday 14 June 2013 22:17:34 Steven Rostedt wrote: > On Sat, 2013-06-15 at 12:02 +1000, Benjamin Herrenschmidt wrote: > > On Fri, 2013-06-14 at 17:06 -0400, Steven Rostedt wrote: > > > I was pretty much able to reproduce this on my PA Semi PPC box. Funny > > > thing is, when I type on the console, it makes progress. Anyway, it > > > seems that powerpc has an issue with irq_work(). I'll try to get some > > > time either tonight or next week to figure it out. > > > > Does this help ? > > It did for me. Rojhalat, did this fix your issue too? > FWIW, since the fix is already applied, but it fixes my problem too. Rojhalat > -- Steve > > > diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c > > index 5cbcf4d..ea185e0 100644 > > --- a/arch/powerpc/kernel/irq.c > > +++ b/arch/powerpc/kernel/irq.c > > @@ -162,7 +162,7 @@ notrace unsigned int __check_irq_replay(void) > > > > * in case we also had a rollover while hard disabled > > */ > > > > local_paca->irq_happened &= ~PACA_IRQ_DEC; > > > > - if (decrementer_check_overflow()) > > + if ((happened & PACA_IRQ_DEC) || decrementer_check_overflow()) > > > > return 0x900; > > > > /* Finally check if an external interrupt happened */ > > > > Cheers, > > Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/