Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752145Ab3FQO6R (ORCPT ); Mon, 17 Jun 2013 10:58:17 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:63167 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170Ab3FQO6P (ORCPT ); Mon, 17 Jun 2013 10:58:15 -0400 MIME-Version: 1.0 In-Reply-To: <20130617143021.GI2718@n2100.arm.linux.org.uk> References: <1371476360-8751-1-git-send-email-jonas.jensen@gmail.com> <5020304.hteFFmWh1u@wuerfel> <20130617143021.GI2718@n2100.arm.linux.org.uk> Date: Mon, 17 Jun 2013 16:58:14 +0200 Message-ID: Subject: Re: [PATCH] ARM: mm: cpu_fa526_do_idle: remove WFI From: Jonas Jensen To: Russell King - ARM Linux Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ulli.kroll@googlemail.com, arm@kernel.org, Florian Fainelli , Imre Kaloz Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 21 On 17 June 2013 16:30, Russell King - ARM Linux wrote: > It replaces the WFI and return with a pure nop, so we will fall through > to cpu_fa526_dcache_clean_area(). Do we really want to clean a random > D cache entry depending on what r0 happened to hold at this point? I > think not... I'm sorry for making the assumption that I know even the most basic ARM assembler... This is not the sort of thing I deal with (and probably shouldn't) on a daily basis. Can I make a guess, remove only mcr and replace it with nop? Best regards, Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/